8262819: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails with release VMs

[DamonFool]

Hi all,

Please review this trivial fix to the failure of TestLinkToNativeRBP.java with release VMs.

Only -XX:+UnlockDiagnosticVMOptions is added for the test.

Thanks.
Best regards,
Jie

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8262819: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails with release VMs

Reviewers

• Roland Westrelin (@rwestrel - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2786/head:pull/2786
$ git checkout pull/2786

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[DamonFool]

/issue add JDK-8262819
/test
/label add hotspot-compiler
/cc hotspot-compiler

[openjdk]

@DamonFool This issue is referenced in the PR title - it will now be updated.

[openjdk]

@DamonFool
The hotspot-compiler label was successfully added.

[openjdk]

@DamonFool The hotspot-compiler label was already applied.

[mlbridge]

Webrevs

• 00: Full (d8eeeb1)

[rwestrel]

Looks good to me

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262819: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails with release VMs

Reviewed-by: roland, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• dd33a8e: 8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c
• 3b350ad: 8261710: SA DSO objects have sizes that are too large
• fdd1093: 8261552: s390: MacroAssembler::encode_klass_not_null() may produce wrong results for non-zero values of narrow klass base
• f5ab7f6: 8262472: Buffer overflow in UNICODE::as_utf8 for zero length output buffer
• 6635d7a: 8261670: Add javadoc for the XML processing limits
• 85b774a: 8255859: Incorrect comments in log.hpp
• c3eb80e: 8262500: HostName entry in VM.info should be a new line
• 9f0f0c9: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

Looks good to me

Thanks @rwestrel for your review.

Is it OK to be pushed?
It's trivial, right?

[shipilev]

Looks good and trivial.

[DamonFool]

Looks good and trivial.

Thanks @shipilev .
/integrate

[openjdk]

@DamonFool Since your change was applied there have been 8 commits pushed to the master branch:

• dd33a8e: 8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c
• 3b350ad: 8261710: SA DSO objects have sizes that are too large
• fdd1093: 8261552: s390: MacroAssembler::encode_klass_not_null() may produce wrong results for non-zero values of narrow klass base
• f5ab7f6: 8262472: Buffer overflow in UNICODE::as_utf8 for zero length output buffer
• 6635d7a: 8261670: Add javadoc for the XML processing limits
• 85b774a: 8255859: Incorrect comments in log.hpp
• c3eb80e: 8262500: HostName entry in VM.info should be a new line
• 9f0f0c9: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings

Your commit was automatically rebased without conflicts.

Pushed as commit 0f6122b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.