Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262819: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails with release VMs #2786

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Mar 2, 2021

Hi all,

Please review this trivial fix to the failure of TestLinkToNativeRBP.java with release VMs.

Only -XX:+UnlockDiagnosticVMOptions is added for the test.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262819: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails with release VMs

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2786/head:pull/2786
$ git checkout pull/2786

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 2, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@DamonFool
Copy link
Member Author

DamonFool commented Mar 2, 2021

/issue add JDK-8262819
/test
/label add hotspot-compiler
/cc hotspot-compiler

@openjdk openjdk bot added the rfr label Mar 2, 2021
@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk openjdk bot added the hotspot-compiler label Mar 2, 2021
@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@DamonFool
The hotspot-compiler label was successfully added.

@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@DamonFool The hotspot-compiler label was already applied.

@mlbridge
Copy link

mlbridge bot commented Mar 2, 2021

Webrevs

Copy link
Contributor

@rwestrel rwestrel left a comment

Looks good to me

@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262819: gc/shenandoah/compiler/TestLinkToNativeRBP.java fails with release VMs

Reviewed-by: roland, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • dd33a8e: 8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c
  • 3b350ad: 8261710: SA DSO objects have sizes that are too large
  • fdd1093: 8261552: s390: MacroAssembler::encode_klass_not_null() may produce wrong results for non-zero values of narrow klass base
  • f5ab7f6: 8262472: Buffer overflow in UNICODE::as_utf8 for zero length output buffer
  • 6635d7a: 8261670: Add javadoc for the XML processing limits
  • 85b774a: 8255859: Incorrect comments in log.hpp
  • c3eb80e: 8262500: HostName entry in VM.info should be a new line
  • 9f0f0c9: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 2, 2021
@DamonFool
Copy link
Member Author

DamonFool commented Mar 2, 2021

Looks good to me

Thanks @rwestrel for your review.

Is it OK to be pushed?
It's trivial, right?

Copy link
Contributor

@shipilev shipilev left a comment

Looks good and trivial.

@DamonFool
Copy link
Member Author

DamonFool commented Mar 2, 2021

Looks good and trivial.

Thanks @shipilev .
/integrate

@openjdk openjdk bot closed this Mar 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 2, 2021
@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@DamonFool Since your change was applied there have been 8 commits pushed to the master branch:

  • dd33a8e: 8262461: handle wcstombsdmp return value correctly in unix awt_InputMethod.c
  • 3b350ad: 8261710: SA DSO objects have sizes that are too large
  • fdd1093: 8261552: s390: MacroAssembler::encode_klass_not_null() may produce wrong results for non-zero values of narrow klass base
  • f5ab7f6: 8262472: Buffer overflow in UNICODE::as_utf8 for zero length output buffer
  • 6635d7a: 8261670: Add javadoc for the XML processing limits
  • 85b774a: 8255859: Incorrect comments in log.hpp
  • c3eb80e: 8262500: HostName entry in VM.info should be a new line
  • 9f0f0c9: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings

Your commit was automatically rebased without conflicts.

Pushed as commit 0f6122b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8262819 branch Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants