8253407: Move max_pow2 from test to src

[stefank]

Small refactoring to move test utility function over to src, so that it can be used in both places.

Patch summary:

• Moved the code
• Replaced duplicate code in round_power_of_2
• Adjusted to the surrounding powerOfTwo.hpp code and only accept integral types.
• Added small gtest. (On the fence whether it's worth it or not)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253407: Move max_pow2 from test to src

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/279/head:pull/279
$ git checkout pull/279

[bridgekeeper]

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stefank The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[stefank]

/label add hotspot-dev

[openjdk]

@stefank
The hotspot label was successfully added.

[stefank]

/label remove hotspot-runtime

[openjdk]

@stefank
The hotspot-runtime label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (d26e03f)

[kimbarrett]

Looks good. The gtest seems fine, and it's already written.

[openjdk]

@stefank This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253407: Move max_pow2 from test to src

Reviewed-by: kbarrett, tschatzl

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch:

• fbfb62d: 8253332: ZGC: Make heap views reservation platform independent
• dad6edb: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode
• edc14f9: 8253286: Use expand_exact() instead of expand_at() for fixed requests in G1
• bba948f: 8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
• 955c2e6: 8253303: G1: Move static initialization of G1FromCardCache to a proper location

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate fbfb62dffefbd60bd24293ca44c99d7f193b6c4e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[stefank]

Thanks for reviewing!

[stefank]

I consider this trivial enough to push it now.

[stefank]

/integrate

[openjdk]

@stefank Since your change was applied there have been 5 commits pushed to the master branch:

• fbfb62d: 8253332: ZGC: Make heap views reservation platform independent
• dad6edb: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode
• edc14f9: 8253286: Use expand_exact() instead of expand_at() for fixed requests in G1
• bba948f: 8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
• 955c2e6: 8253303: G1: Move static initialization of G1FromCardCache to a proper location

Your commit was automatically rebased without conflicts.

Pushed as commit 7e49eae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.