Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262876: Shenandoah: Fix comments regarding VM_ShenandoahOperation inheritances #2796

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 2, 2021

please review this comment only fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262876: Shenandoah: Fix comments regarding VM_ShenandoahOperation inheritances

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2796/head:pull/2796
$ git checkout pull/2796

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 2, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 2, 2021
@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@zhengyu123 The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Mar 2, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 2, 2021

Webrevs

rkennke
rkennke approved these changes Mar 2, 2021
Copy link
Contributor

@rkennke rkennke left a comment

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262876: Shenandoah: Fix comments regarding VM_ShenandoahOperation inheritances

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • f304b74: 8261859: gc/g1/TestStringDeduplicationTableRehash.java failed with "RuntimeException: 'Rehash Count: 0' found in stdout"
  • f18c019: 8247373: ArraysSupport.newLength doc, test, and exception message
  • 96c4321: 8262424: Change multiple get_java_xxx() functions in thread.cpp into one function
  • 0de6abd: 8260966: (fs) Consolidate Linux and macOS implementations of UserDefinedFileAttributeView

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 2, 2021
@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Mar 2, 2021

/integrate

@openjdk openjdk bot closed this Mar 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 2, 2021
@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@zhengyu123 Since your change was applied there have been 5 commits pushed to the master branch:

  • 20b9ba5: 8262875: doccheck: empty paragraphs, etc in java.base module
  • f304b74: 8261859: gc/g1/TestStringDeduplicationTableRehash.java failed with "RuntimeException: 'Rehash Count: 0' found in stdout"
  • f18c019: 8247373: ArraysSupport.newLength doc, test, and exception message
  • 96c4321: 8262424: Change multiple get_java_xxx() functions in thread.cpp into one function
  • 0de6abd: 8260966: (fs) Consolidate Linux and macOS implementations of UserDefinedFileAttributeView

Your commit was automatically rebased without conflicts.

Pushed as commit c92f3bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123 zhengyu123 deleted the JDK-8262876-sh-vmopt-comment branch May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated shenandoah
2 participants