8248532: Every time I change keyboard language at my MacBook, Java crashes #28

prsadhuk · 2020-09-06T08:31:23Z

It seems the observer either needs to be removed when it is dealloced/destroyed (Otherwise Notification Centre would send the notification to the destroyed object resulting in crash.)

and we need to do the below in dealloc, which solves the crash in my system.

NSNotificationCenter *nc = [NSNotificationCenter defaultCenter]; [nc removeObserver:self]

But it is not done for LWCToolkit, so I changed the observer as is being done there, to make existing @implementation class as observer

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8248532: Every time I change keyboard language at my MacBook, Java crashes

Reviewers

Sergey Bylokhov (@mrserb - Reviewer)
Phil Race (@prrace - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/28/head:pull/28
$ git checkout pull/28

…ashes

bridgekeeper · 2020-09-06T08:34:37Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-06T08:35:24Z

@prsadhuk The following labels will be automatically applied to this pull request: awt. When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

mlbridge · 2020-09-06T08:38:26Z

Webrevs

00: Full (50e876f)

openjdk · 2020-09-06T20:14:14Z

@prsadhuk This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8248532: Every time I change keyboard language at my MacBook, Java crashes

Reviewed-by: serb, prr

If you would like to add a summary, use the /summary command.
To credit additional contributors, use the /contributor command.
To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 39 commits pushed to the master branch:

d560964: 8252794: Creation of JNIMethodBlock should be done with a leaf lock
5fef8dd: 8235229: Compilation against a modular, multi-release JAR erroneous with --release
382b8fe: 8240751: Shenandoah: fold ShenandoahTracer definition
c98417e: 8250840: some tests use --enable-preview unnecessarily
c655b70: 8252916: Newline in object field values list of ScopeDesc should be removed
30fa8d5: 8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types
26c7218: 8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions
e20004d: 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles
63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
001e51d: 8250563: Add KVHashtable::add_if_absent
... and 29 more: https://git.openjdk.java.net/jdk/compare/ae5a6dde2d77680da5cf4b64c76ab2b4059d3fc4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d56096471ba042f28c8c2a695c856ca7da156689.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

prrace · 2020-09-06T22:33:14Z

/reviewers 2

openjdk · 2020-09-06T22:33:26Z

@prrace
The number of required reviews for this PR is now set to 2.

prrace · 2020-09-06T22:47:11Z

You say you need to use NSDistributedNotificationCenter but you don't. So I am confused.

prsadhuk · 2020-09-07T04:17:39Z

The problem of crash is about not having proper observer. As per
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/Notifications/Articles/NotificationCenters.html
NSNotificationCenter delivers notifications to observers synchronously whereas NSDistributedNotificationCenter notification is usually delivered to the main thread’s run loop, thus not depending on observer setup.
Both will work but since we use NSNotificationCenter in mac so far, it seems prudent to use the same methodology for this case too, so I have rectified the observer setup.

prsadhuk · 2020-09-09T12:31:50Z

Hi Phil,
Is there any more feedback on this PR? If not, can you please approve.

prrace · 2020-09-09T13:12:16Z

You still have not resolved my confusion. Please read your own evaluation in the bug report which says you
will use NSDistributedNotificationCenter.
Is the evaluation wrong ?

prsadhuk · 2020-09-09T13:22:20Z

Yes, the evaluation in the bug report was the first shot on this issue, when I did not know that mac code historically did not use NSDistributedNotificationCenter, rather they use NSNotificationCenter and those did not crash. So, I investigated further to find out it's the observer setup which needs to be amened. I will amend it the evaluation in the bug report. NSDistributedCenter will work but it is more better to use NSNotificationCenter with proper observer setup which I did in 2nd iteration. Hope this clarifies.

prsadhuk · 2020-09-09T13:42:28Z

/integrate

openjdk · 2020-09-09T13:43:14Z

@prsadhuk Since your change was applied there have been 39 commits pushed to the master branch:

d560964: 8252794: Creation of JNIMethodBlock should be done with a leaf lock
5fef8dd: 8235229: Compilation against a modular, multi-release JAR erroneous with --release
382b8fe: 8240751: Shenandoah: fold ShenandoahTracer definition
c98417e: 8250840: some tests use --enable-preview unnecessarily
c655b70: 8252916: Newline in object field values list of ScopeDesc should be removed
30fa8d5: 8157729: examples in LinkedHashMap and LinkedHashSet class doc use raw types
26c7218: 8252773: [TESTBUG] serviceability/jvmti/GetObjectSizeOverflow fails due to OOM conditions
e20004d: 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles
63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
001e51d: 8250563: Add KVHashtable::add_if_absent
... and 29 more: https://git.openjdk.java.net/jdk/compare/ae5a6dde2d77680da5cf4b64c76ab2b4059d3fc4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6329de4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

…penjdk#28) Corresponding to typetools/checker-framework#3159 Co-authored-by: Werner Dietl <wdietl@gmail.com>

This patch optimizes the backend implementation of VectorMaskToLong for AArch64, given a more efficient approach to mov value bits from predicate register to general purpose register as x86 PMOVMSK[1] does, by using BEXT[2] which is available in SVE2. With this patch, the final code (input mask is byte type with SPECIESE_512, generated on an SVE vector reg size of 512-bit QEMU emulator) changes as below: Before: mov z16.b, p0/z, #1 fmov x0, d16 orr x0, x0, x0, lsr openjdk#7 orr x0, x0, x0, lsr openjdk#14 orr x0, x0, x0, lsr openjdk#28 and x0, x0, #0xff fmov x8, v16.d[1] orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#8 orr x8, xzr, #0x2 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#16 orr x8, xzr, #0x3 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#24 orr x8, xzr, #0x4 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#32 mov x8, #0x5 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#40 orr x8, xzr, #0x6 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#48 orr x8, xzr, #0x7 whilele p1.d, xzr, x8 lastb x8, p1, z16.d orr x8, x8, x8, lsr openjdk#7 orr x8, x8, x8, lsr openjdk#14 orr x8, x8, x8, lsr openjdk#28 and x8, x8, #0xff orr x0, x0, x8, lsl openjdk#56 After: mov z16.b, p0/z, #1 mov z17.b, #1 bext z16.d, z16.d, z17.d mov z17.d, #0 uzp1 z16.s, z16.s, z17.s uzp1 z16.h, z16.h, z17.h uzp1 z16.b, z16.b, z17.b mov x0, v16.d[0] [1] https://www.felixcloutier.com/x86/pmovmskb [2] https://developer.arm.com/documentation/ddi0602/2020-12/SVE-Instructions/BEXT--Gather-lower-bits-from-positions-selected-by-bitmask- Change-Id: Ia983a20c89f76403e557ac21328f2f2e05dd08e0

* Enhance ifThenElse. * Expose block builder with break label. * Docs and tests. * Doc. * Review feedback. * Unused import.

…cv-port-26 RISC-V: loom: misc improvements

* Enhance ifThenElse. * Expose block builder with break label. * Docs and tests. * Doc. * Review feedback. * Unused import.

JVM-1917: bail out if c2 merges 2 objects with different ObjIDs

It's delaying the results from CI

8248532: Every time I change keyboard language at my MacBook, Java cr…

50e876f

…ashes

openjdk bot added the rfr Pull request is ready for review label Sep 6, 2020

openjdk bot added the awt client-libs-dev@openjdk.org label Sep 6, 2020

mrserb approved these changes Sep 6, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 6, 2020

openjdk bot removed the ready Pull request is ready to be integrated label Sep 6, 2020

prrace approved these changes Sep 9, 2020

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 9, 2020

openjdk bot closed this Sep 9, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Sep 9, 2020

openjdk bot removed the rfr Pull request is ready for review label Sep 9, 2020

prsadhuk deleted the 8248532-mackbdcrash branch September 9, 2020 14:11

cushon pushed a commit to cushon/jdk that referenced this pull request Apr 2, 2021

Annotate parameters of java.lang.AssertionError(String, Throwable) (o…

1d0ed02

…penjdk#28) Corresponding to typetools/checker-framework#3159 Co-authored-by: Werner Dietl <wdietl@gmail.com>

asotona pushed a commit to asotona/jdk that referenced this pull request Oct 7, 2022

Ifthenelse (openjdk#28)

482add7

* Enhance ifThenElse. * Expose block builder with break label. * Docs and tests. * Doc. * Review feedback. * Unused import.

zhengxiaolinX pushed a commit to zhengxiaolinX/jdk that referenced this pull request Oct 17, 2022

Merge pull request openjdk#28 from zhengxiaolinX/JDK-8286301-loom-ris…

3c84117

…cv-port-26 RISC-V: loom: misc improvements

asotona pushed a commit to asotona/jdk that referenced this pull request Feb 6, 2023

Ifthenelse (openjdk#28)

23d3124

* Enhance ifThenElse. * Expose block builder with break label. * Docs and tests. * Doc. * Review feedback. * Unused import.

caojoshua pushed a commit to caojoshua/jdk that referenced this pull request May 8, 2023

Merge pull request openjdk#28 from navyxliu/PEA_parser

31ae332

JVM-1917: bail out if c2 merges 2 objects with different ObjIDs

robehn pushed a commit to robehn/jdk that referenced this pull request Aug 15, 2023

Disable linux-aarch64 testing on GitHub CI (openjdk#28)

4952ed4

It's delaying the results from CI

lmesnik mentioned this pull request Nov 7, 2024

8343741: SA jstack --mixed should print information about VM locks #21943

Closed

3 tasks

lmesnik mentioned this pull request Nov 15, 2024

8343741: SA jstack --mixed should print information about VM locks #22171

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8248532: Every time I change keyboard language at my MacBook, Java crashes #28

8248532: Every time I change keyboard language at my MacBook, Java crashes #28

prsadhuk commented Sep 6, 2020 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 6, 2020

openjdk bot commented Sep 6, 2020

mlbridge bot commented Sep 6, 2020

openjdk bot commented Sep 6, 2020 •

edited

Loading

prrace commented Sep 6, 2020

openjdk bot commented Sep 6, 2020

prrace commented Sep 6, 2020

prsadhuk commented Sep 7, 2020

prsadhuk commented Sep 9, 2020

prrace commented Sep 9, 2020

prsadhuk commented Sep 9, 2020

prsadhuk commented Sep 9, 2020

openjdk bot commented Sep 9, 2020

8248532: Every time I change keyboard language at my MacBook, Java crashes #28

8248532: Every time I change keyboard language at my MacBook, Java crashes #28

Conversation

prsadhuk commented Sep 6, 2020 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Sep 6, 2020

openjdk bot commented Sep 6, 2020

mlbridge bot commented Sep 6, 2020

Webrevs

openjdk bot commented Sep 6, 2020 • edited Loading

prrace commented Sep 6, 2020

openjdk bot commented Sep 6, 2020

prrace commented Sep 6, 2020

prsadhuk commented Sep 7, 2020

prsadhuk commented Sep 9, 2020

prrace commented Sep 9, 2020

prsadhuk commented Sep 9, 2020

prsadhuk commented Sep 9, 2020

openjdk bot commented Sep 9, 2020

prsadhuk commented Sep 6, 2020 •

edited by openjdk bot

Loading

openjdk bot commented Sep 6, 2020 •

edited

Loading