8262915: java.awt.color.ColorSpace.getName() is not thread-safe #2801

mrserb · 2021-03-03T03:46:59Z

The java.awt.color.ColorSpace.getName() method does not use any kind of synchronization to properly initialize and use the static cache for the color components names.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8262915: java.awt.color.ColorSpace.getName() is not thread-safe

Reviewers

Alexander Zvegintsev (@azvegint - Reviewer)
Alexey Ivanov (@aivanov-jdk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2801/head:pull/2801
$ git checkout pull/2801

bridgekeeper · 2021-03-03T03:48:08Z

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-03-03T03:49:27Z

@mrserb The following label will be automatically applied to this pull request:

2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mrserb · 2021-03-03T03:54:32Z

src/java.desktop/share/classes/java/awt/color/ColorSpace.java

+    /**
+     * Lazy-initialized names of components in the color space.
+     */
+    private transient volatile String [] compName;


The volatile keyword is the only one necessary to fix this bug, everything else is a cleanup.

mrserb · 2021-03-03T03:55:42Z

src/java.desktop/share/classes/java/awt/color/ColorSpace.java

@@ -447,60 +451,37 @@ public int getNumComponents() {
    /**
     * Returns the name of the component given the component index.
     *
-     * @param  idx the component index
+     * @param  component the component index


All other methods use the "component" as a name of the component index.

I guess it will require a CSR request.

nope, it is just renaming of the parameter

mrserb · 2021-03-03T03:57:53Z

src/java.desktop/share/classes/java/awt/color/ColorSpace.java

        if (compName == null) {
-            switch (type) {


the "switch statement" is replaced by the "switch expression"

mlbridge · 2021-03-03T06:08:04Z

Webrevs

00: Full (78af71a)

azvegint · 2021-03-03T19:44:33Z

src/java.desktop/share/classes/java/awt/color/ColorSpace.java

@@ -447,60 +451,37 @@ public int getNumComponents() {
    /**
     * Returns the name of the component given the component index.
     *
-     * @param  idx the component index
+     * @param  component the component index


I guess it will require a CSR request.

openjdk · 2021-03-03T19:45:17Z

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262915: java.awt.color.ColorSpace.getName() is not thread-safe

Reviewed-by: azvegint, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

268d9b7: 8261447: MethodInvocationCounters frequently run into overflow
75aa154: 8259267: Refactor LoaderLeak shell test as java test.
a118185: 8261862: Expand discussion of rationale for BigDecimal equals/compareTo semantics
2d2ef08: 8262885: Shenandoah: FullGC prologue does not need to save/restore heap has_forwarded_object flag
1d2c1e6: 8248314: Parallel: Parallelize parallel full gc Adjust Roots phase
3d3eb5c: 8262368: wrong verifier message for bogus return type
6d3c858: 8259235: javac crashes while attributing super method invocation
bf90e85: 8262926: JDK-8260966 broke AIX build
54dfd79: 8262256: C2 intrinsincs should not modify IR when bailing out
0265ab6: 8262466: linux libsaproc/DwarfParser.cpp delete DwarfParser object in early return
... and 1 more: https://git.openjdk.java.net/jdk/compare/044e2a2a499ff63dffae355b2254ec6bfcc3e01d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mrserb · 2021-03-03T20:26:26Z

/integrate

openjdk · 2021-03-03T20:27:27Z

@mrserb Since your change was applied there have been 11 commits pushed to the master branch:

268d9b7: 8261447: MethodInvocationCounters frequently run into overflow
75aa154: 8259267: Refactor LoaderLeak shell test as java test.
a118185: 8261862: Expand discussion of rationale for BigDecimal equals/compareTo semantics
2d2ef08: 8262885: Shenandoah: FullGC prologue does not need to save/restore heap has_forwarded_object flag
1d2c1e6: 8248314: Parallel: Parallelize parallel full gc Adjust Roots phase
3d3eb5c: 8262368: wrong verifier message for bogus return type
6d3c858: 8259235: javac crashes while attributing super method invocation
bf90e85: 8262926: JDK-8260966 broke AIX build
54dfd79: 8262256: C2 intrinsincs should not modify IR when bailing out
0265ab6: 8262466: linux libsaproc/DwarfParser.cpp delete DwarfParser object in early return
... and 1 more: https://git.openjdk.java.net/jdk/compare/044e2a2a499ff63dffae355b2254ec6bfcc3e01d...master

Your commit was automatically rebased without conflicts.

Pushed as commit b397472.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Update ColorSpace.java

78af71a

openjdk bot added the 2d client-libs-dev@openjdk.org label Mar 3, 2021

mrserb commented Mar 3, 2021

View reviewed changes

mrserb marked this pull request as ready for review March 3, 2021 06:04

openjdk bot added the rfr Pull request is ready for review label Mar 3, 2021

azvegint approved these changes Mar 3, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 3, 2021

aivanov-jdk approved these changes Mar 3, 2021

View reviewed changes

openjdk bot closed this Mar 3, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2021

mrserb deleted the JDK-8262915 branch March 3, 2021 20:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8262915: java.awt.color.ColorSpace.getName() is not thread-safe #2801

8262915: java.awt.color.ColorSpace.getName() is not thread-safe #2801

mrserb commented Mar 3, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 3, 2021

openjdk bot commented Mar 3, 2021

mrserb Mar 3, 2021

mrserb Mar 3, 2021

azvegint Mar 3, 2021

mrserb Mar 3, 2021

mrserb Mar 3, 2021

mlbridge bot commented Mar 3, 2021

azvegint Mar 3, 2021

openjdk bot commented Mar 3, 2021 •

edited

Loading

mrserb commented Mar 3, 2021

openjdk bot commented Mar 3, 2021

8262915: java.awt.color.ColorSpace.getName() is not thread-safe #2801

8262915: java.awt.color.ColorSpace.getName() is not thread-safe #2801

Conversation

mrserb commented Mar 3, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Mar 3, 2021

openjdk bot commented Mar 3, 2021

mrserb Mar 3, 2021

Choose a reason for hiding this comment

mrserb Mar 3, 2021

Choose a reason for hiding this comment

azvegint Mar 3, 2021

Choose a reason for hiding this comment

mrserb Mar 3, 2021

Choose a reason for hiding this comment

mrserb Mar 3, 2021

Choose a reason for hiding this comment

mlbridge bot commented Mar 3, 2021

Webrevs

azvegint Mar 3, 2021

Choose a reason for hiding this comment

openjdk bot commented Mar 3, 2021 • edited Loading

mrserb commented Mar 3, 2021

openjdk bot commented Mar 3, 2021

mrserb commented Mar 3, 2021 •

edited by openjdk bot

Loading

openjdk bot commented Mar 3, 2021 •

edited

Loading