Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8262926 JDK-8260966 broke AIX build #2805

Closed
wants to merge 1 commit into from

Conversation

@overheadhunter
Copy link
Contributor

@overheadhunter overheadhunter commented Mar 3, 2021

Fixed access modifier of isExtendedAttributesEnabled which has been moved to super class.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2805/head:pull/2805
$ git checkout pull/2805

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 3, 2021

👋 Welcome back overheadhunter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@overheadhunter The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

tstuefe
tstuefe approved these changes Mar 3, 2021
Copy link
Member

@tstuefe tstuefe left a comment

Looks good to me, and Arno tested it. Thanks for the quick response!

I think this falls under the trivial rule, which means you can integrate it right away without having to wait 24hrs.

Thanks, Thomas

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@overheadhunter This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262926: JDK-8260966 broke AIX build

Reviewed-by: stuefe, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 54dfd79: 8262256: C2 intrinsincs should not modify IR when bailing out
  • 0265ab6: 8262466: linux libsaproc/DwarfParser.cpp delete DwarfParser object in early return

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Mar 3, 2021
@overheadhunter
Copy link
Contributor Author

@overheadhunter overheadhunter commented Mar 3, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@overheadhunter
Your change (at version 9b4ac4a) is now ready to be sponsored by a Committer.

Loading

@overheadhunter
Copy link
Contributor Author

@overheadhunter overheadhunter commented Mar 3, 2021

@tstuefe Can you sponsor this PR?

Loading

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Mar 3, 2021

/sponsor

Loading

@openjdk openjdk bot closed this Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@RealCLanger @overheadhunter Since your change was applied there have been 2 commits pushed to the master branch:

  • 54dfd79: 8262256: C2 intrinsincs should not modify IR when bailing out
  • 0265ab6: 8262466: linux libsaproc/DwarfParser.cpp delete DwarfParser object in early return

Your commit was automatically rebased without conflicts.

Pushed as commit bf90e85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 3, 2021

Webrevs

Loading

@overheadhunter overheadhunter deleted the JDK-8262926 branch Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants