New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs #281
Conversation
…sing the reserve can result in repeated full gcs" This reverts commit fa30241. Fix some merge error
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
@tschatzl The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good backout. Disappointing...
@tschatzl This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
Mailing list message from Thomas Schatzl on hotspot-gc-dev: Hi, On 21.09.20 12:03, Kim Barrett wrote: thanks for your and Stefan's reviews. I will integrate as soon as Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/integrate |
@tschatzl Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit bba948f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
can I have some reviews for this change that reverts commit fa30241.
Fix some merge error in this hunk:
From 3570f5a9, 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length , the method "max_expandable_regions()" has been changed to "max_regions()" so the first use of it in the hunk
@@ -108,11 +107,14 @@ void G1Policy::init(G1CollectedHeap* g1h, G1CollectionSet* collection_set) {
_young_gen_sizer->adjust_max_new_size(_g1h->max_regions()); // <------------- here!
Did not revert cleanly. Everything else is unchanged.
Testing: local compilation. tier1-tier3 running
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/281/head:pull/281
$ git checkout pull/281