Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs #281

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Sep 21, 2020

Hi all,

can I have some reviews for this change that reverts commit fa30241.

Fix some merge error in this hunk:

From 3570f5a, 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length , the method "max_expandable_regions()" has been changed to "max_regions()" so the first use of it in the hunk

@@ -108,11 +107,14 @@ void G1Policy::init(G1CollectedHeap* g1h, G1CollectionSet* collection_set) {

  • if (!use_adaptive_young_list_length()) {
  • _young_list_fixed_length = _young_gen_sizer->min_desired_young_length();
  • }
    _young_gen_sizer->adjust_max_new_size(_g1h->max_regions()); // <------------- here!

Did not revert cleanly. Everything else is unchanged.

Testing: local compilation. tier1-tier3 running


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/281/head:pull/281
$ git checkout pull/281

…sing the reserve can result in repeated full gcs"

This reverts commit fa30241.

Fix some merge error
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2020

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@tschatzl The following label will be automatically applied to this pull request: hotspot-gc.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-gc label Sep 21, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2020

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Looks like a good backout. Disappointing...

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@tschatzl This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs

Reviewed-by: kbarrett, sjohanss
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

  • 955c2e6: 8253303: G1: Move static initialization of G1FromCardCache to a proper location

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 955c2e629279c9c625764895e65f3623bce9c19e.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 21, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2020

Mailing list message from Thomas Schatzl on hotspot-gc-dev:

Hi,

On 21.09.20 12:03, Kim Barrett wrote:

thanks for your and Stefan's reviews. I will integrate as soon as
testing comes back clean if nobody objects.

Thanks,
Thomas

Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Sep 21, 2020

/integrate

@openjdk openjdk bot closed this Sep 21, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@tschatzl Since your change was applied there has been 1 commit pushed to the master branch:

  • 955c2e6: 8253303: G1: Move static initialization of G1FromCardCache to a proper location

Your commit was automatically rebased without conflicts.

Pushed as commit bba948f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the tschatzl:8253411-backout-redo-young-gen-sizing branch Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants