Skip to content

8262973: Verify ParCompactionManager instance in PCAdjustPointerClosure #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8262973: Verify ParCompactionManager instance in PCAdjustPointerClosure #2813

wants to merge 2 commits into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Mar 3, 2021 •
edited by openjdk bot
Loading

Verify the correct ParCompactionManager instance is used by VM/GC threads and some general cleanup.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262973: Verify ParCompactionManager instance in PCAdjustPointerClosure

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2813/head:pull/2813
$ git checkout pull/2813

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2021

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 3, 2021
@openjdk
Copy link

openjdk bot commented Mar 3, 2021

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 3, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2021 •
edited
Loading

Webrevs

kimbarrett
kimbarrett approved these changes Mar 4, 2021
View reviewed changes
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor nits. Otherwise looks good.

src/hotspot/share/gc/parallel/psCompactionManager.cpp Outdated
#ifdef ASSERT
void ParCompactionManager::verify_all_marking_stack_empty() {
uint parallel_gc_threads = ParallelGCThreads;
for (uint i=0; i<=parallel_gc_threads; i++) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use spaces around operators, here and line 193.

src/hotspot/share/gc/parallel/psParallelCompact.cpp Outdated
ParCompactionManager* cm = ParCompactionManager::manager_array(0);
// Update the deferred objects, if any. Any compaction manager can be used.
// However, since the current thread is VM thread, we use the rightful one
// to keep the verification logic happy.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using a different cm makes the verification logic unhappy, that suggests "Any compaction manager can be used" isn't exactly true. Maybe something like "In principle, any compaction manager would do. However, ..."

@openjdk
Copy link

openjdk bot commented Mar 4, 2021 •
edited
Loading

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262973: Verify ParCompactionManager instance in PCAdjustPointerClosure

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • f56c918: 8262837: handle split_USE correctly
  • bd1a806: 8263040: fix for JDK-8262122 fails validate-source
  • a6427c8: 8259709: Disable SHA-1 XML Signatures
  • ef5e13d: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 222a17e: 8262122: [TESTBUG] Shenandoah-specific variant of TestReferenceRefersTo
  • a777e82: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
  • d2c4ed0: 8262000: jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java failed with "OutOfMemoryError: Java heap space"
  • 94f26e4: 8261450: JShell crashes with SIOOBE in tab completion
  • b817855: 8262935: Add missing logging to sun.net.httpserver.ServerImpl
  • 2251319: 8262828: Format of OS information is different on macOS
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/1d2c1e62898c0e9ce05131e257dce8517e90cd1a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kimbarrett, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 4, 2021
tschatzl
tschatzl approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm apart from the issues Kim mentioned.

@albertnetymk
Copy link
Member Author

All fixed as suggested.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@albertnetymk
Your change (at version cf96a66) is now ready to be sponsored by a Committer.

@tschatzl
Copy link
Contributor

tschatzl commented Mar 5, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 5, 2021

@tschatzl This change does not need sponsoring - the author is allowed to integrate it.

@albertnetymk
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Mar 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 5, 2021
@openjdk
Copy link

openjdk bot commented Mar 5, 2021

@albertnetymk Since your change was applied there have been 31 commits pushed to the master branch:

  • d91550e: 8262998: Vector API intrinsincs should not modify IR when bailing out
  • 80182f9: 8260925: HttpsURLConnection does not work with other JSSE provider.
  • dbef0ec: 6323374: (coll) Optimize Collections.unmodifiable* and synchronized*
  • ee09bad: 8262300: jpackage app-launcher fails on linux when using JDK11 based runtime
  • 351889f: 8262508: Vector API's ergonomics is incorrect
  • 718d4d4: 8262989: Vectorize VectorShuffle checkIndexes, wrapIndexes and laneIsValid methods
  • c8b23e2: 8262064: Make compiler/ciReplay tests ignore lambdas in compilation replay
  • 02fbcb5: 8261532: Archived superinterface class cannot be accessed
  • 109af7b: 8261518: jpackage looks for main module in current dir when there is no module-path
  • e61a3ba: 8239386: handle ContendedPaddingWidth in vm_version_aarch64
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/1d2c1e62898c0e9ce05131e257dce8517e90cd1a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9730266.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the pgc branch March 5, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschatzl tschatzl tschatzl approved these changes

@kimbarrett kimbarrett kimbarrett approved these changes

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated sponsor Pull request is ready to be sponsored
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertnetymk @tschatzl @kimbarrett