Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239386: handle ContendedPaddingWidth in vm_version_aarch64 #2814

Closed
wants to merge 1 commit into from

Conversation

@danlemmond
Copy link
Contributor

@danlemmond danlemmond commented Mar 3, 2021

Handle ContendedPaddingWidth the same way other architectures do

Passes Hotspot Tier1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8239386: handle ContendedPaddingWidth in vm_version_aarch64

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2814/head:pull/2814
$ git checkout pull/2814

Handle ContendedPaddingWidth the same way other architectures do
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 3, 2021

👋 Welcome back danlemmond! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@danlemmond The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Mar 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 3, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

⚠️ @danlemmond the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8239386
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@danlemmond This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8239386: handle ContendedPaddingWidth in vm_version_aarch64

Reviewed-by: aph, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • f56c918: 8262837: handle split_USE correctly
  • bd1a806: 8263040: fix for JDK-8262122 fails validate-source
  • a6427c8: 8259709: Disable SHA-1 XML Signatures
  • ef5e13d: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 222a17e: 8262122: [TESTBUG] Shenandoah-specific variant of TestReferenceRefersTo
  • a777e82: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
  • d2c4ed0: 8262000: jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java failed with "OutOfMemoryError: Java heap space"
  • 94f26e4: 8261450: JShell crashes with SIOOBE in tab completion
  • b817855: 8262935: Add missing logging to sun.net.httpserver.ServerImpl
  • 2251319: 8262828: Format of OS information is different on macOS
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/c92f3bc37ac900e0df6115ddae212d3c3af6c20a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 4, 2021
@danlemmond
Copy link
Contributor Author

@danlemmond danlemmond commented Mar 4, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@danlemmond
Your change (at version e666167) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

@phohensee phohensee commented Mar 4, 2021

/sponsor

@openjdk openjdk bot closed this Mar 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@phohensee @danlemmond Since your change was applied there have been 34 commits pushed to the master branch:

  • f56c918: 8262837: handle split_USE correctly
  • bd1a806: 8263040: fix for JDK-8262122 fails validate-source
  • a6427c8: 8259709: Disable SHA-1 XML Signatures
  • ef5e13d: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 222a17e: 8262122: [TESTBUG] Shenandoah-specific variant of TestReferenceRefersTo
  • a777e82: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
  • d2c4ed0: 8262000: jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java failed with "OutOfMemoryError: Java heap space"
  • 94f26e4: 8261450: JShell crashes with SIOOBE in tab completion
  • b817855: 8262935: Add missing logging to sun.net.httpserver.ServerImpl
  • 2251319: 8262828: Format of OS information is different on macOS
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/c92f3bc37ac900e0df6115ddae212d3c3af6c20a...master

Your commit was automatically rebased without conflicts.

Pushed as commit e61a3ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants