8371432: [BACKOUT] 8359256: AArch64: Use SHA3 GPR intrinsic where it's faster

[TobiHartmann]

Clean backout of JDK-8359256 due to failures with different tests in our CI (see JBS for details).

Thanks,
Tobias

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371432: [BACKOUT] 8359256: AArch64: Use SHA3 GPR intrinsic where it's faster (Bug - P2)

Reviewers

• Marc Chevalier (@marc-chevalier - Committer)
• Emanuel Peter (@eme64 - Reviewer)
• SendaoYan (@sendaoYan - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28189/head:pull/28189
$ git checkout pull/28189

Update a local copy of the PR:
$ git checkout pull/28189
$ git pull https://git.openjdk.org/jdk.git pull/28189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28189

View PR using the GUI difftool:
$ git pr show -t 28189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28189.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[eme64]

Looks good to me. Thanks for taking care of this!

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371432: [BACKOUT] 8359256: AArch64: Use SHA3 GPR intrinsic where it's faster

Reviewed-by: mchevalier, epeter, syan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7348197f)

[TobiHartmann]

Thanks for the quick reviews, Marc and Emanuel. Running sanity testing before integration.

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 3d6824e.
Since your change was applied there have been 3 commits pushed to the master branch:

• 48bbc95: 8371388: [BACKOUT] JDK-8365047: Remove exception handler stub code in C2
• 205a163: 8340840: jshell ClassFormatError when making inner class static
• 866faa9: 8366577: Deprecate java.net.Socket::setPerformancePreferences

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit 3d6824e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[bulasevich]

Ouch. Sorry for the trouble. I focused on performance testing across multiple machines and missed an obvious jtreg failure in the process. My bad. I’ll come back with an updated PR next week. Thanks for fixing it!