Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8262064: Make compiler/ciReplay tests ignore lambdas in compilation replay #2821

Closed
wants to merge 1 commit into from

Conversation

@dean-long
Copy link
Member

@dean-long dean-long commented Mar 4, 2021

Don't include hidden classes in replay file. I consider this a temporary fix because I plan to remove the dumping of subclassses in a later RFE.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262064: Make compiler/ciReplay tests ignore lambdas in compilation replay

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2821/head:pull/2821
$ git checkout pull/2821

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 4, 2021

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@dean-long The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@dean-long dean-long marked this pull request as ready for review Mar 4, 2021
@openjdk openjdk bot added the rfr label Mar 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 4, 2021

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262064: Make compiler/ciReplay tests ignore lambdas in compilation replay

Reviewed-by: thartmann, kvn, iignatyev

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 02fbcb5: 8261532: Archived superinterface class cannot be accessed
  • 109af7b: 8261518: jpackage looks for main module in current dir when there is no module-path
  • e61a3ba: 8239386: handle ContendedPaddingWidth in vm_version_aarch64
  • f56c918: 8262837: handle split_USE correctly
  • bd1a806: 8263040: fix for JDK-8262122 fails validate-source
  • a6427c8: 8259709: Disable SHA-1 XML Signatures
  • ef5e13d: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 222a17e: 8262122: [TESTBUG] Shenandoah-specific variant of TestReferenceRefersTo
  • a777e82: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
  • d2c4ed0: 8262000: jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java failed with "OutOfMemoryError: Java heap space"
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/b397472e4f030e546fd6c565c336dd2fb0a6f60e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 4, 2021
@dean-long
Copy link
Member Author

@dean-long dean-long commented Mar 4, 2021

Thanks Tobias!

@openjdk openjdk bot removed the ready label Mar 4, 2021
Copy link
Member

@iignatev iignatev left a comment

LGTM.

@dean-long, before integrating, could you please update the PR's or bug's title so they match?

@dean-long dean-long changed the title 8262064: compiler/ciReplay/TestVMNoCompLevel.java failed due to exit code 1 8262064: compiler/ciReplay tests ignore lambdas in compilation replay Mar 4, 2021
@dean-long
Copy link
Member Author

@dean-long dean-long commented Mar 4, 2021

Thanks, Vladimir and Igor.

@dean-long
Copy link
Member Author

@dean-long dean-long commented Mar 4, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@dean-long This PR has not yet been marked as ready for integration.

@dean-long dean-long changed the title 8262064: compiler/ciReplay tests ignore lambdas in compilation replay 8262064: Make compiler/ciReplay tests ignore lambdas in compilation replay Mar 4, 2021
@dean-long dean-long changed the title 8262064: Make compiler/ciReplay tests ignore lambdas in compilation replay JDK-8262064: Make compiler/ciReplay tests ignore lambdas in compilation replay Mar 4, 2021
@openjdk openjdk bot added the ready label Mar 4, 2021
@dean-long
Copy link
Member Author

@dean-long dean-long commented Mar 4, 2021

/integrate

@openjdk openjdk bot closed this Mar 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2021

@dean-long Since your change was applied there have been 19 commits pushed to the master branch:

  • 02fbcb5: 8261532: Archived superinterface class cannot be accessed
  • 109af7b: 8261518: jpackage looks for main module in current dir when there is no module-path
  • e61a3ba: 8239386: handle ContendedPaddingWidth in vm_version_aarch64
  • f56c918: 8262837: handle split_USE correctly
  • bd1a806: 8263040: fix for JDK-8262122 fails validate-source
  • a6427c8: 8259709: Disable SHA-1 XML Signatures
  • ef5e13d: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 222a17e: 8262122: [TESTBUG] Shenandoah-specific variant of TestReferenceRefersTo
  • a777e82: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards
  • d2c4ed0: 8262000: jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java failed with "OutOfMemoryError: Java heap space"
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/b397472e4f030e546fd6c565c336dd2fb0a6f60e...master

Your commit was automatically rebased without conflicts.

Pushed as commit c8b23e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dean-long dean-long deleted the dean-long:JDK-8262064 branch Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants