Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262828: Format of OS information is different on macOS #2824

Closed
wants to merge 1 commit into from

Conversation

jyukutyo
Copy link
Contributor

@jyukutyo jyukutyo commented Mar 4, 2021

This pull request derives from JDK-8262507. Unlike Windows and Linux, there isn't a newline after the OS label in os information of a hs_error log file and jcmd VM.info on macOS. So this adds the newline.

I checked output in a hs_err log and jcmd VM.info.

OS:
uname: Darwin MacBook-Pro.local 19.6.0 Darwin Kernel Version 19.6.0: Tue Nov 10 00:10:30 PST 2020; root:xnu-6153.141.10~1/RELEASE_X86_64 x86_64
OS uptime: 2 days 5:13 hours
rlimit (soft/hard): STACK 8192k/65532k , CORE 0k/infinity , NPROC 5568/8352 , NOFILE 10240/65535 , AS infinity/infinity , CPU infinity/infinity , DATA infinity/infinity , FSIZE infinity/infinity , MEMLOCK infinity/infinity , RSS infinity/infinity
load average: 1.69 1.75 1.76

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262828: Format of OS information is different on macOS

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2824/head:pull/2824
$ git checkout pull/2824

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2021

👋 Welcome back ksakata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@jyukutyo The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 4, 2021
@jyukutyo jyukutyo changed the title 8262828: Newline is needed after OS label on macOS for consistency 8262828: Format of OS information is different on macOS Mar 4, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial. Lets not overthink this one :)

Thanks,
David

@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@jyukutyo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262828: Format of OS information is different on macOS

Reviewed-by: dholmes, ysuenaga

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 4cfecce: 8261730: C2 compilation fails with assert(store->find_edge(load) != -1) failed: missing precedence edge
  • 7915a1f: 8262950: Restructure compiler/intrinsics/TestRotate.java for easier compilation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @YaSuenag) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 4, 2021
Copy link
Member

@YaSuenag YaSuenag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can sponsor you.

@YaSuenag
Copy link
Member

YaSuenag commented Mar 4, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@YaSuenag The change author (@jyukutyo) must issue an integrate command before the integration can be sponsored.

@jyukutyo
Copy link
Contributor Author

jyukutyo commented Mar 4, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@jyukutyo
Your change (at version 4ae1072) is now ready to be sponsored by a Committer.

@YaSuenag
Copy link
Member

YaSuenag commented Mar 4, 2021

/sponsor

@openjdk openjdk bot closed this Mar 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@YaSuenag @jyukutyo Since your change was applied there have been 2 commits pushed to the master branch:

  • 4cfecce: 8261730: C2 compilation fails with assert(store->find_edge(load) != -1) failed: missing precedence edge
  • 7915a1f: 8262950: Restructure compiler/intrinsics/TestRotate.java for easier compilation

Your commit was automatically rebased without conflicts.

Pushed as commit 2251319.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jyukutyo jyukutyo deleted the JDK-8262828_osinfo_macos branch June 15, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants