Skip to content

8371701: Add ability to set NUMA-affinity for threads#28261

Closed
jsikstro wants to merge 6 commits intoopenjdk:masterfrom
jsikstro:JDK-8371701_numa_affinity_threads
Closed

8371701: Add ability to set NUMA-affinity for threads#28261
jsikstro wants to merge 6 commits intoopenjdk:masterfrom
jsikstro:JDK-8371701_numa_affinity_threads

Conversation

@jsikstro
Copy link
Member

@jsikstro jsikstro commented Nov 12, 2025

Hello,

This PR adds support for setting the affinity of threads to run on CPUs associated with specific NUMA nodes on Linux. Support for this is needed for JDK-8371702 to improve performance in the Relocation Phase of ZGC on a NUMA machine.

Testing:

  • I've run significant performance testing locally on a NUMA machine and performed functional testing to see that the affinity is actually changed. Affinity of a thread can be inspected on Linux using taskset -cp <tid>.
  • Running through Oracle's tier1-2

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371701: Add ability to set NUMA-affinity for threads (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28261/head:pull/28261
$ git checkout pull/28261

Update a local copy of the PR:
$ git checkout pull/28261
$ git pull https://git.openjdk.org/jdk.git pull/28261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28261

View PR using the GUI difftool:
$ git pr show -t 28261

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28261.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371701: Add ability to set NUMA-affinity for threads

Reviewed-by: aboldtch, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8ae4ea8: 8371262: sun/security/pkcs11/Cipher/KeyWrap tests may silently skip

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 12, 2025
@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@jsikstro The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

Copy link
Member

@xmas92 xmas92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 14, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 24, 2025
@jsikstro
Copy link
Member Author

/touch

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@jsikstro The pull request is being re-evaluated and the inactivity timeout has been reset.

@jsikstro
Copy link
Member Author

/issue add 8371701

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@jsikstro This issue is referenced in the PR title - it will now be updated.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 24, 2025
@jsikstro
Copy link
Member Author

Thank you for the reviews! @albertnetymk @xmas92
/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

Going to push as commit 0a963b6.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 8ae4ea8: 8371262: sun/security/pkcs11/Cipher/KeyWrap tests may silently skip

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 24, 2025
@openjdk openjdk bot closed this Nov 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2025
@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@jsikstro Pushed as commit 0a963b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants