8371721: Refactor checkTrusted methods in X509TrustManagerImpl

[artur-oracle]

The 3 checkTrusted methods in X509TrustManagerImpl have a lot of repeating code that can be moved into a helper method.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371721: Refactor checkTrusted methods in X509TrustManagerImpl (Enhancement - P5)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer) Review applies to 0cabd3c4
• Sean Coffey (@coffeys - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28275/head:pull/28275
$ git checkout pull/28275

Update a local copy of the PR:
$ git checkout pull/28275
$ git pull https://git.openjdk.org/jdk.git pull/28275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28275

View PR using the GUI difftool:
$ git pr show -t 28275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28275.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@artur-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371721: Refactor checkTrusted methods in X509TrustManagerImpl

Reviewed-by: coffeys, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 256 new commits pushed to the master branch:

• 692edc4: 8373443: Update --release 26 symbol information for JDK 26 build 27
• 2a1c676: 8373464: Test JdkManagementCheckSince.java fails after JDK-8369736
• b0bd0c3: 8372759: Test build/AbsPathsInImage.java fails after JDK-8370438
• ... and 253 more: https://git.openjdk.org/jdk/compare/c0abecdd1ffe59314bc17aeec0684cdda33a222d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@artur-oracle The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (f9233a75)
• 02: Full - Incremental (0cabd3c4)
• 01: Full (d2399cf0)
• 00: Full (3ebae2bf)

[djelinski]

I'd keep at least some of the class JavaDoc. Other than that, LGTM. Thanks!

[artur-oracle]

/integrate

[openjdk]

Going to push as commit a99f340.
Since your change was applied there have been 267 commits pushed to the master branch:

• d854a04: 8373411: Crash when PrintSharedArchiveAndExit is enabled but shared heap is disabled
• 4100143: 8373225: GenShen: More adaptive old-generation growth heuristics
• a05d5d2: 8373579: Problem list compiler/runtime/Test7196199.java
• ... and 264 more: https://git.openjdk.org/jdk/compare/c0abecdd1ffe59314bc17aeec0684cdda33a222d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@artur-oracle Pushed as commit a99f340.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.