-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8257913: Add more known library locations to simplify Linux cross-compilation #2833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
/label remove 2d |
@shipilev |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now and definitely a nice change to find these libs automatically.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@shipilev Since your change was applied there have been 29 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 61cff4d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Current cross-compilation configurations require adding the whole lot of configure options to make it find the dependencies: freetype and X11 libs are the only problematic dependencies. We should be able to specify just the
--with-sysroot
, and get everything else autodetected.After this patch, doing
sh ./configure --openjdk-target=powerpc64le-linux-gnu --with-sysroot=/chroots/ppc64el
, where chroot isdebootstrap
-ed chroot as per our build docs, is enough to get everything configured. See the GH Actions definition to see what options are not needed anymore.Some explanations:
*-gnuabi64
is needed formips64el
*-gnueabihf
is needed forarmhf
$OPENJDK_TARGET_CPU_AUTOCONF-linux-gnu
is needed forpowerpc*
, because OpenJDK build rewritesVAR_CPU
toppc
, leading to mismatch.Additional testing:
x86_64-linux-gnu
i686-linux-gnu
alpha-linux-gnu
aarch64-linux-gnu
arm-linux-gnueabihf
arm-linux-gnueabi
mipsel-linux-gnu
mips64el-linux-gnuabi64
powerpc-linux-gnu
powerpc64-linux-gnu
powerpc64le-linux-gnu
m68k-linux-gnu
sh4-linux-gnu
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2833/head:pull/2833
$ git checkout pull/2833