8368977: Provide clear naming for AVX10 identifiers#28344
8368977: Provide clear naming for AVX10 identifiers#28344missa-prime wants to merge 4 commits intoopenjdk:masterfrom
Conversation
… conversion whenever available
|
👋 Welcome back missa! A progress list of the required criteria for merging this PR into |
|
@missa-prime This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jatin-bhateja, @mhaessig, @iwanowww) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@missa-prime The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
/label add hotspot-compiler-dev |
|
@jatin-bhateja |
|
@jatin-bhateja The |
jatin-bhateja
left a comment
There was a problem hiding this comment.
LGTM, naming now follows the AVX10 versions sheme where an instruction supported by a version is guaranteed to be supported by all the version above it.
mhaessig
left a comment
There was a problem hiding this comment.
Thank you for this clarification, @missa-prime. This is very helpful.
I'll run testing on our side and report results.
iwanowww
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the cleanup!
|
/integrate |
|
@missa-prime |
|
/sponsor |
|
Going to push as commit 4f1dcf8.
Your commit was automatically rebased without conflicts. |
|
@iwanowww @missa-prime Pushed as commit 4f1dcf8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a simple change that renames all AVX10 identifiers to explicitly show which sub-versions are in use. Right now, AVX10.2 is the only case to worry about. The JTREG tests listed below were used to verify correctness with the recommended JVM options mentioned in corresponding source files. Each test included runs through emulation with AVX10.2 enabled and disabled to exercise all possible paths. All modifications and tests used OpenJDK v26-b24 as the baseline build.
jtreg:test/hotspot/jtreg/compiler/codegen/TestByteDoubleVect.javajtreg:test/hotspot/jtreg/compiler/codegen/TestByteFloatVect.javajtreg:test/hotspot/jtreg/compiler/codegen/TestIntDoubleVect.javajtreg:test/hotspot/jtreg/compiler/codegen/TestIntFloatVect.javajtreg:test/hotspot/jtreg/compiler/codegen/TestLongDoubleVect.javajtreg:test/hotspot/jtreg/compiler/codegen/TestLongFloatVect.javajtreg:test/hotspot/jtreg/compiler/codegen/TestShortDoubleVect.javajtreg:test/hotspot/jtreg/compiler/codegen/TestShortFloatVect.javajtreg:test/hotspot/jtreg/compiler/floatingpoint/ScalarFPtoIntCastTest.javajtreg:test/hotspot/jtreg/compiler/vectorapi/VectorFPtoIntCastTest.javajtreg:test/hotspot/jtreg/compiler/vectorization/runner/ArrayTypeConvertTest.javajtreg:test/jdk/jdk/incubator/vector/Double64VectorTests.javajtreg:test/jdk/jdk/incubator/vector/Double128VectorTests.javajtreg:test/jdk/jdk/incubator/vector/Double256VectorTests.javajtreg:test/jdk/jdk/incubator/vector/Double512VectorTests.javajtreg:test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.javajtreg:test/jdk/jdk/incubator/vector/Float64VectorTests.javajtreg:test/jdk/jdk/incubator/vector/Float128VectorTests.javajtreg:test/jdk/jdk/incubator/vector/Float256VectorTests.javajtreg:test/jdk/jdk/incubator/vector/Float512VectorTests.javajtreg:test/jdk/jdk/incubator/vector/FloatMaxVectorTests.javajtreg:test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorOperations.javajtreg:test/hotspot/jtreg/compiler/c2/irTests/TestFloat16ScalarOperations.javaProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28344/head:pull/28344$ git checkout pull/28344Update a local copy of the PR:
$ git checkout pull/28344$ git pull https://git.openjdk.org/jdk.git pull/28344/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28344View PR using the GUI difftool:
$ git pr show -t 28344Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28344.diff
Using Webrev
Link to Webrev Comment