Skip to content

8368977: Provide clear naming for AVX10 identifiers#28344

Closed
missa-prime wants to merge 4 commits intoopenjdk:masterfrom
missa-prime:user/missa-prime/nomenclature
Closed

8368977: Provide clear naming for AVX10 identifiers#28344
missa-prime wants to merge 4 commits intoopenjdk:masterfrom
missa-prime:user/missa-prime/nomenclature

Conversation

@missa-prime
Copy link
Contributor

@missa-prime missa-prime commented Nov 17, 2025

This is a simple change that renames all AVX10 identifiers to explicitly show which sub-versions are in use. Right now, AVX10.2 is the only case to worry about. The JTREG tests listed below were used to verify correctness with the recommended JVM options mentioned in corresponding source files. Each test included runs through emulation with AVX10.2 enabled and disabled to exercise all possible paths. All modifications and tests used OpenJDK v26-b24 as the baseline build.

  1. jtreg:test/hotspot/jtreg/compiler/codegen/TestByteDoubleVect.java
  2. jtreg:test/hotspot/jtreg/compiler/codegen/TestByteFloatVect.java
  3. jtreg:test/hotspot/jtreg/compiler/codegen/TestIntDoubleVect.java
  4. jtreg:test/hotspot/jtreg/compiler/codegen/TestIntFloatVect.java
  5. jtreg:test/hotspot/jtreg/compiler/codegen/TestLongDoubleVect.java
  6. jtreg:test/hotspot/jtreg/compiler/codegen/TestLongFloatVect.java
  7. jtreg:test/hotspot/jtreg/compiler/codegen/TestShortDoubleVect.java
  8. jtreg:test/hotspot/jtreg/compiler/codegen/TestShortFloatVect.java
  9. jtreg:test/hotspot/jtreg/compiler/floatingpoint/ScalarFPtoIntCastTest.java
  10. jtreg:test/hotspot/jtreg/compiler/vectorapi/VectorFPtoIntCastTest.java
  11. jtreg:test/hotspot/jtreg/compiler/vectorization/runner/ArrayTypeConvertTest.java
  12. jtreg:test/jdk/jdk/incubator/vector/Double64VectorTests.java
  13. jtreg:test/jdk/jdk/incubator/vector/Double128VectorTests.java
  14. jtreg:test/jdk/jdk/incubator/vector/Double256VectorTests.java
  15. jtreg:test/jdk/jdk/incubator/vector/Double512VectorTests.java
  16. jtreg:test/jdk/jdk/incubator/vector/DoubleMaxVectorTests.java
  17. jtreg:test/jdk/jdk/incubator/vector/Float64VectorTests.java
  18. jtreg:test/jdk/jdk/incubator/vector/Float128VectorTests.java
  19. jtreg:test/jdk/jdk/incubator/vector/Float256VectorTests.java
  20. jtreg:test/jdk/jdk/incubator/vector/Float512VectorTests.java
  21. jtreg:test/jdk/jdk/incubator/vector/FloatMaxVectorTests.java
  22. jtreg:test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorOperations.java
  23. jtreg:test/hotspot/jtreg/compiler/c2/irTests/TestFloat16ScalarOperations.java

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368977: Provide clear naming for AVX10 identifiers (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28344/head:pull/28344
$ git checkout pull/28344

Update a local copy of the PR:
$ git checkout pull/28344
$ git pull https://git.openjdk.org/jdk.git pull/28344/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28344

View PR using the GUI difftool:
$ git pr show -t 28344

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28344.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2025

👋 Welcome back missa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 17, 2025

@missa-prime This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368977: Provide clear naming for AVX10 identifiers

Reviewed-by: jbhateja, mhaessig, vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 17744fb: 8373628: jpackage doesn't print to console until completetion
  • d054865: 8371975: Apply java.io.Serial annotations in java.security.sasl

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jatin-bhateja, @mhaessig, @iwanowww) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 17, 2025
@openjdk
Copy link

openjdk bot commented Nov 17, 2025

@missa-prime The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@missa-prime missa-prime marked this pull request as ready for review November 24, 2025 23:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2025

Webrevs

@jatin-bhateja
Copy link
Member

/label add hotspot-compiler-dev

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@jatin-bhateja
The hotspot-compiler label was successfully added.

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@jatin-bhateja The jdk label was not set.

Copy link
Member

@jatin-bhateja jatin-bhateja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, naming now follows the AVX10 versions sheme where an instruction supported by a version is guaranteed to be supported by all the version above it.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 10, 2025
@missa-prime
Copy link
Contributor Author

@eme64, @mhaessig Ok to test?

@iwanowww In case you want to glance through changes.

Copy link
Contributor

@mhaessig mhaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this clarification, @missa-prime. This is very helpful.

I'll run testing on our side and report results.

Copy link
Contributor

@mhaessig mhaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing tier1-3 passed

Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the cleanup!

@missa-prime
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 13, 2025
@openjdk
Copy link

openjdk bot commented Dec 13, 2025

@missa-prime
Your change (at version be7f5c8) is now ready to be sponsored by a Committer.

@iwanowww
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 13, 2025

Going to push as commit 4f1dcf8.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 17744fb: 8373628: jpackage doesn't print to console until completetion
  • d054865: 8371975: Apply java.io.Serial annotations in java.security.sasl

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 13, 2025
@openjdk openjdk bot closed this Dec 13, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Dec 13, 2025
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 13, 2025
@openjdk
Copy link

openjdk bot commented Dec 13, 2025

@iwanowww @missa-prime Pushed as commit 4f1dcf8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@missa-prime missa-prime deleted the user/missa-prime/nomenclature branch December 14, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants