8371948: TestStackOverflowDuringInit.java fails xss too small on linux-aarch64

[sendaoYan]

Hi all,

On linux-aarch64, when page size is 64K, the minimal java thread stack size is 448K. So this PR increase the minimal java thread stack size in test/hotspot/jtreg/runtime/ClassInitErrors/TestStackOverflowDuringInit.java. Below is the calculation formula for the minimal java thread stack size:

page_size = 64K
_java_thread_min_stack_allowed = 72K
_stack_red_zone_size = align_up(StackRedPages * unit, page_size) = align_up(1*4K, 64K) = 64K
_stack_yellow_zone_size = align_up(StackYellowPages * unit, page_size) = align_up(2*4K, 64K) = 64K
_stack_reserved_zone_size = align_up(StackReservedPages * unit, page_size) = align_up(1*4K, 64K) = 64K
_stack_shadow_zone_size = align_up(StackShadowPages * unit, page_size) = align_up(25*4K, 64K) = 128K
_java_thread_min_stack_allowed = align_up(72K+64K+64K+64K+128K, 64K) = 448K

This PR add whitebox API getMinimumJavaStackSize() to the the allowd minimum java stack size, and get the allowed minimum java stack size in test/hotspot/jtreg/runtime/ClassInitErrors/TestStackOverflowDuringInit.java

Change has been verified locally both on linux-x64 and linux-aarch64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371948: TestStackOverflowDuringInit.java fails xss too small on linux-aarch64 (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28352/head:pull/28352
$ git checkout pull/28352

Update a local copy of the PR:
$ git checkout pull/28352
$ git pull https://git.openjdk.org/jdk.git pull/28352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28352

View PR using the GUI difftool:
$ git pr show -t 28352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28352.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371948: TestStackOverflowDuringInit.java fails xss too small on linux-aarch64

Reviewed-by: dholmes, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 166 new commits pushed to the master branch:

• a31e6e0: 8373593: Support latest VS2026 MSC_VER in abstract_vm_version.cpp
• 8598306: 8364766: C2: Improve Value() of DivI and DivL for non-constant inputs
• e678050: 8367341: C2: apply KnownBits and unsigned bounds to And / Or operations
• ... and 163 more: https://git.openjdk.org/jdk/compare/674cc3eeca77f1f2a6d937b1df5c5cd8a13c2d31...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (ee8c621f)
• 03: Full - Incremental (f45cc0cb)
• 02: Full - Incremental (bad8596c)
• 01: Full - Incremental (b3f4fa96)
• 00: Full (633f6a79)

[dholmes-ora]

A more resilient change would be to add a WhiteBox API to obtain the minimum stack for the actual platform in use, and then exec the VM with that as an -Xss value. Is that something you can do?

[sendaoYan]

A more resilient change would be to add a WhiteBox API to obtain the minimum stack for the actual platform in use, and then exec the VM with that as an -Xss value. Is that something you can do?

Okey, Thanks for the suggestion, I will try this in this PR later.

[openjdk]

@sendaoYan hotspot has been added to this pull request based on files touched in new commit(s).

[dholmes-ora]

Looking good. Just a couple of minor issues.

Thanks

[dholmes-ora]

Looks good. Thanks

[sendaoYan]

Looking for second reviewer since touch the hotspot files.

[sendaoYan]

Thanks for the suggestions and reviews @dholmes-ora @theRealAph

/integrate

[openjdk]

Going to push as commit 360777c.
Since your change was applied there have been 183 commits pushed to the master branch:

• f0add88: 8373837: "assert(thread->is_VM_thread() || thread->is_Java_thread()) failed: Must be VMThread or JavaThread" on macosx-aarch64-26
• 6231646: 8373208: Make Atomic class template constant initializable
• f88cbfb: 8374044: Docs build fails: Cannot determine current path
• ... and 180 more: https://git.openjdk.org/jdk/compare/674cc3eeca77f1f2a6d937b1df5c5cd8a13c2d31...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 360777c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.