8250804: Can't set the application icon image for Unity WM on Linux.

[azvegint]

As of now we can have two icons: on the side dock and on the top bar.
But this test was written for an old time Unity with an icon in the side dock only.

Icon at the top by default is displayed as grayscale(the actual reason of submitting bug report).
BTW it may not be presented depending on Gnome Shell settings.

setIconImage() seems to be working as expected in this case, but we need to clarify the test's instruction.

Besides that the test has another issue: it does not fail on pressing "Fail" button. It is also fixed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8250804: Can't set the application icon image for Unity WM on Linux.

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Pankaj Bansal (@pankaj-bansal - Reviewer)
• Alexander Zuev (@azuev-java - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2838/head:pull/2838
$ git checkout pull/2838

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d7f3e2f)

[mrserb]

Does this test work fine on the macOS? Looks like it was reported here:

https://bugs.openjdk.java.net/browse/JDK-8250804?focusedCommentId=14379402&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14379402

[mrserb]

O, I see that you made it Linux only.

[azvegint]

Yes, it does not work on macOS.
For changing dock icon on macOS you should use java.awt.Taskbar#setIconImage or assign it with application bundle.

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8250804: Can't set the application icon image for Unity WM on Linux.

Reviewed-by: serb, pbansal, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• e1cad97: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java
• 2c0507e: 8261812: C2 compilation fails with assert(!had_error) failed: bad dominance
• 9755782: 8157682: @inheritdoc doesn't work with @exception
• 8c13d26: 8263050: move HtmlDocletWriter.verticalSeparator to IndexWriter
• 8d3de4b: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
• 75fb7cc: 8259228: Zero: rewrite (put|get)field from if-else chains to switches
• 9730266: 8262973: Verify ParCompactionManager instance in PCAdjustPointerClosure
• d91550e: 8262998: Vector API intrinsincs should not modify IR when bailing out
• 80182f9: 8260925: HttpsURLConnection does not work with other JSSE provider.
• dbef0ec: 6323374: (coll) Optimize Collections.unmodifiable* and synchronized*
• ... and 2 more: https://git.openjdk.java.net/jdk/compare/718d4d487c55971c568a1d3e29f70c2fb5a11034...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azvegint]

/integrate

[openjdk]

@azvegint Since your change was applied there have been 14 commits pushed to the master branch:

• fa43f92: 8261845: File permissions of packages built by jpackage
• 23ee60d: 8261008: Optimize Xor
• e1cad97: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java
• 2c0507e: 8261812: C2 compilation fails with assert(!had_error) failed: bad dominance
• 9755782: 8157682: @inheritdoc doesn't work with @exception
• 8c13d26: 8263050: move HtmlDocletWriter.verticalSeparator to IndexWriter
• 8d3de4b: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
• 75fb7cc: 8259228: Zero: rewrite (put|get)field from if-else chains to switches
• 9730266: 8262973: Verify ParCompactionManager instance in PCAdjustPointerClosure
• d91550e: 8262998: Vector API intrinsincs should not modify IR when bailing out
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/718d4d487c55971c568a1d3e29f70c2fb5a11034...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2afbd5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.