8263054: [testbug] SharedArchiveConsistency.java reuses jsa files

[iklam]

SharedArchiveConsistency.java runs a child process with a JSA file. Then, it modifies the JSA file, and then reuses this same JSA file to run another child process.

However, on Windows, after first child process has exited, some sort of file lock is still held on the JSA file, so when we try to modify the JSA file for the second process, sometimes we get the "The requested operation cannot be performed on a file with a user-mapped section open" error.

The fix is to always create a new JSA file for every new test case, and never modify/reuse the JSA files. (We have been following this rule for other CDS tests).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263054: [testbug] SharedArchiveConsistency.java reuses jsa files

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 826c7c9
• Yumin Qi (@yminqi - Reviewer) ⚠️ Review applies to 826c7c9

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2839/head:pull/2839
$ git checkout pull/2839

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e3fdb34)
• 00: Full (826c7c9)

[dholmes-ora]

Hi Ioi,

Seems reasonable. One comment below.

Thanks,
David

[dholmes-ora]

Not clear why you need to create the file if you are going to immediately replace it.

[iklam]

I removed the call to createNewFile and it seems to work just fine. I don't remember why the call was there before. I'll do more testing before integrating.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263054: [testbug] SharedArchiveConsistency.java reuses jsa files

Reviewed-by: dholmes, minqi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[yminqi]

LGTM.

[iklam]

Thanks @dholmes-ora and @yminqi for the review.
/integrate

[openjdk]

@iklam Since your change was applied there have been 3 commits pushed to the master branch:

• 2afbd5d: 8250804: Can't set the application icon image for Unity WM on Linux.
• fa43f92: 8261845: File permissions of packages built by jpackage
• 23ee60d: 8261008: Optimize Xor

Your commit was automatically rebased without conflicts.

Pushed as commit 75a5be8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.