8370910: Cleanup terminology of UUID vs Global Identifiers in UUID#28435
8370910: Cleanup terminology of UUID vs Global Identifiers in UUID#28435kieran-farrell wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back kfarrell! A progress list of the required criteria for merging this PR into |
|
@kieran-farrell This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 793 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @AlanBateman, @RogerRiggs) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@kieran-farrell The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
Looks straight-forward. |
|
PR description edited to include correct Bug ID |
| @@ -35,7 +35,7 @@ | |||
| * A class that represents an immutable universally unique identifier (UUID). | |||
There was a problem hiding this comment.
Maybe change this to "Universally Unique IDentifier (UUID)" too.
| * A UUID represents a 128-bit value. | ||
| * | ||
| * <p> There exist different variants of these global identifiers. The methods | ||
| * <p> There exist different variants of these UUIDs. The methods |
There was a problem hiding this comment.
What would you think about replacing this paragraph with this:
"This class is primarily designed for manipulating Leach-Salz variant UUIDs, but it also supports the creation of UUIDs of other variants."
|
@kieran-farrell Nudge, see the suggestion above. |
Yes, let's try to get this done before the fork so it goes with the main update to the UUID class description. |
| * <p> There exist different variants of these UUIDs. The methods | ||
| * of this class are for manipulating the Leach-Salz variant, although the | ||
| * constructors allow the creation of any variant of UUID (described below). |
There was a problem hiding this comment.
Something like this?
| * <p> There exist different variants of these UUIDs. The methods | |
| * of this class are for manipulating the Leach-Salz variant, although the | |
| * constructors allow the creation of any variant of UUID (described below). | |
| * <p>This class is primarily designed for manipulating Leach-Salz variant UUIDs, | |
| * but it also supports the creation of UUIDs of other variants. |
|
Don't wait but for doc-only changes there is a bit more time until RPD2. |
|
Apologies for the hold up I was OOO. I've pushed the update now. |
|
/integrate |
|
@kieran-farrell |
RogerRiggs
left a comment
There was a problem hiding this comment.
Looks good, thanks for the followup.
|
/sponsor |
|
Going to push as commit 6aeabd4.
Your commit was automatically rebased without conflicts. |
|
@RogerRiggs @kieran-farrell Pushed as commit 6aeabd4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport :jdk26 |
|
@RogerRiggs the backport was successfully created on the branch backport-RogerRiggs-6aeabd4b-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
Replacing 'global identifier' with 'UUID' for consistancy in the spec as suggested during the review of JDK-8334015.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28435/head:pull/28435$ git checkout pull/28435Update a local copy of the PR:
$ git checkout pull/28435$ git pull https://git.openjdk.org/jdk.git pull/28435/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28435View PR using the GUI difftool:
$ git pr show -t 28435Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28435.diff
Using Webrev
Link to Webrev Comment