Skip to content

8370910: Cleanup terminology of UUID vs Global Identifiers in UUID#28435

Closed
kieran-farrell wants to merge 3 commits intoopenjdk:masterfrom
kieran-farrell:8370910
Closed

8370910: Cleanup terminology of UUID vs Global Identifiers in UUID#28435
kieran-farrell wants to merge 3 commits intoopenjdk:masterfrom
kieran-farrell:8370910

Conversation

@kieran-farrell
Copy link
Contributor

@kieran-farrell kieran-farrell commented Nov 20, 2025

Replacing 'global identifier' with 'UUID' for consistancy in the spec as suggested during the review of JDK-8334015.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370910: Cleanup terminology of UUID vs Global Identifiers in UUID (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28435/head:pull/28435
$ git checkout pull/28435

Update a local copy of the PR:
$ git checkout pull/28435
$ git pull https://git.openjdk.org/jdk.git pull/28435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28435

View PR using the GUI difftool:
$ git pr show -t 28435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28435.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2025

👋 Welcome back kfarrell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@kieran-farrell This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370910: Cleanup terminology of UUID vs Global Identifiers in UUID

Reviewed-by: alanb, rriggs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 793 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @AlanBateman, @RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 20, 2025
@openjdk
Copy link

openjdk bot commented Nov 20, 2025

@kieran-farrell The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2025

Webrevs

@RogerRiggs
Copy link
Contributor

Looks straight-forward.
There is a typo in the PR description of the earlier issue, should be 8334025.

@kieran-farrell
Copy link
Contributor Author

PR description edited to include correct Bug ID

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2025
@@ -35,7 +35,7 @@
* A class that represents an immutable universally unique identifier (UUID).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to "Universally Unique IDentifier (UUID)" too.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 21, 2025
* A UUID represents a 128-bit value.
*
* <p> There exist different variants of these global identifiers. The methods
* <p> There exist different variants of these UUIDs. The methods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you think about replacing this paragraph with this:

"This class is primarily designed for manipulating Leach-Salz variant UUIDs, but it also supports the creation of UUIDs of other variants."

@RogerRiggs
Copy link
Contributor

@kieran-farrell Nudge, see the suggestion above.

@AlanBateman
Copy link
Contributor

@kieran-farrell Nudge, see the suggestion above.

Yes, let's try to get this done before the fork so it goes with the main update to the UUID class description.

Comment on lines 38 to 40
* <p> There exist different variants of these UUIDs. The methods
* of this class are for manipulating the Leach-Salz variant, although the
* constructors allow the creation of any variant of UUID (described below).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this?

Suggested change
* <p> There exist different variants of these UUIDs. The methods
* of this class are for manipulating the Leach-Salz variant, although the
* constructors allow the creation of any variant of UUID (described below).
* <p>This class is primarily designed for manipulating Leach-Salz variant UUIDs,
* but it also supports the creation of UUIDs of other variants.

@RogerRiggs
Copy link
Contributor

Don't wait but for doc-only changes there is a bit more time until RPD2.

@kieran-farrell
Copy link
Contributor Author

Apologies for the hold up I was OOO. I've pushed the update now.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2025
@kieran-farrell
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

@kieran-farrell
Your change (at version 20573f2) is now ready to be sponsored by a Committer.

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the followup.

@RogerRiggs
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 15, 2025

Going to push as commit 6aeabd4.
Since your change was applied there have been 793 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 15, 2025
@openjdk openjdk bot closed this Dec 15, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

@RogerRiggs @kieran-farrell Pushed as commit 6aeabd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs
Copy link
Contributor

/backport :jdk26

@openjdk
Copy link

openjdk bot commented Dec 15, 2025

@RogerRiggs the backport was successfully created on the branch backport-RogerRiggs-6aeabd4b-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 6aeabd4b from the openjdk/jdk repository.

The commit being backported was authored by Kieran Farrell on 15 Dec 2025 and was reviewed by Alan Bateman, Roger Riggs and Jaikiran Pai.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-RogerRiggs-6aeabd4b-jdk26:backport-RogerRiggs-6aeabd4b-jdk26
$ git checkout backport-RogerRiggs-6aeabd4b-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-RogerRiggs-6aeabd4b-jdk26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants