8263091: Remove CharacterData.isOtherUppercase/-Lowercase

[cl4es]

This patch removes the CharacterData.isOtherUppercase and isOtherLowercase methods. It also exploits the fact that isOtherUppercase is always false for all codepoints in the CharacterDataLatin1 range for a small speed-up.

I have no means to test if this is correct on PPC, which has intrinsics for isLowerCase/isUpperCase, but unless I'm reading the code wrong the intrinsic for isLowerCase on PPC already appears to effectively do the fused logic of isLowerCase(ch) || isOtherLowerCase(ch) since it handles the two values where isLowerCase and isOtherLowercase disagrees (0xaa, 0xba), which means this change should make the intrinsic and the java code be in better agreement.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263091: Remove CharacterData.isOtherUppercase/-Lowercase

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Naoto Sato (@naotoj - Reviewer)
• Iris Clark (@irisclark - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2846/head:pull/2846
$ git checkout pull/2846

[bridgekeeper]

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cl4es The following labels will be automatically applied to this pull request:

• build
• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[cl4es]

Microbenchmark results, org.openjdk.bench.java.lang.Characters

OOTB:

Benchmark               (codePoint)  Mode  Cnt   Score   Error  Units
Characters.isLowerCase          176  avgt    5  13.812 ± 0.060  ns/op
Characters.isUpperCase          176  avgt    5  13.812 ± 0.062  ns/op

Benchmark               (codePoint)  Mode  Cnt   Score   Error  Units
Characters.isLowerCase          176  avgt    5  13.825 ± 0.096  ns/op
Characters.isUpperCase          176  avgt    5  12.555 ± 0.033  ns/op

~1.1x speed-up for Character.isUpperCase in the latin 1 range

-Xint:

Benchmark               (codePoint)  Mode  Cnt    Score    Error  Units
Characters.isLowerCase          176  avgt    5  754.756 ± 20.815  ns/op
Characters.isUpperCase          176  avgt    5  755.403 ± 15.645  ns/op

Benchmark               (codePoint)  Mode  Cnt    Score   Error  Units
Characters.isLowerCase          176  avgt    5  606.923 ± 1.569  ns/op
Characters.isUpperCase          176  avgt    5  521.073 ± 7.439  ns/op

1.25x speed-up for isLowerCase and 1.45x speed-up for isUpperCase when interpreting, translating to minor startup / warmup win on some examined apps.

[cl4es]

/label remove build

[openjdk]

@cl4es
The build label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (e2dd484)

[openjdk]

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263091: Remove CharacterData.isOtherUppercase/-Lowercase

Reviewed-by: rriggs, naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 75a5be8: 8263054: [testbug] SharedArchiveConsistency.java reuses jsa files
• 2afbd5d: 8250804: Can't set the application icon image for Unity WM on Linux.
• fa43f92: 8261845: File permissions of packages built by jpackage
• 23ee60d: 8261008: Optimize Xor
• e1cad97: 8262862: Harden tests sun/security/x509/URICertStore/ExtensionsWithLDAP.java and krb5/canonicalize/Test.java
• 2c0507e: 8261812: C2 compilation fails with assert(!had_error) failed: bad dominance
• 9755782: 8157682: @inheritdoc doesn't work with @exception
• 8c13d26: 8263050: move HtmlDocletWriter.verticalSeparator to IndexWriter
• 8d3de4b: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
• 75fb7cc: 8259228: Zero: rewrite (put|get)field from if-else chains to switches
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/d2c4ed08a2f78c22e4d59b6c29d29abf3202199d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cl4es]

/integrate

[openjdk]

@cl4es Since your change was applied there have been 35 commits pushed to the master branch:

• 13625be: 8263090: Avoid reading volatile fields twice in Locale.getDefault(Category)
• 61cff4d: 8257913: Add more known library locations to simplify Linux cross-compilation
• 22a3117: 8263137: Typos in sun.security.ssl.RenegoInfoExtension
• 18fc350: 8259886: Improve SSL session cache performance and scalability
• 3844ce4: 8261247: some compiler/whitebox/ tests fail w/ DeoptimizeALot
• f2d0152: 8263043: Add test to verify order of tag output
• 7182985: 8263104: fix warnings for empty paragraphs
• 5eb2091: 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"
• 75a5be8: 8263054: [testbug] SharedArchiveConsistency.java reuses jsa files
• 2afbd5d: 8250804: Can't set the application icon image for Unity WM on Linux.
• ... and 25 more: https://git.openjdk.java.net/jdk/compare/d2c4ed08a2f78c22e4d59b6c29d29abf3202199d...master

Your commit was automatically rebased without conflicts.

Pushed as commit a0c3f24.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.