Skip to content

8371651: [AArch64] Populate CPU _features flag on Windows#28461

Open
dhanalla wants to merge 2 commits intoopenjdk:masterfrom
dhanalla:win-cpu-feat-aarch64
Open

8371651: [AArch64] Populate CPU _features flag on Windows#28461
dhanalla wants to merge 2 commits intoopenjdk:masterfrom
dhanalla:win-cpu-feat-aarch64

Conversation

@dhanalla
Copy link

@dhanalla dhanalla commented Nov 21, 2025

Populate CPU feature flags on Windows/AArch64 to enable CPU features CRC32, AES, SHA1, SHA2, SHA3, SHA512, PMULL, ASIMD, LSE, SVE, SVE2 and SVEBITPERM.

Tests performed: jtreg tier1 & tier2


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371651: [AArch64] Populate CPU _features flag on Windows (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28461/head:pull/28461
$ git checkout pull/28461

Update a local copy of the PR:
$ git checkout pull/28461
$ git pull https://git.openjdk.org/jdk.git pull/28461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28461

View PR using the GUI difftool:
$ git pr show -t 28461

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28461.diff

Using Webrev

Link to Webrev Comment

@dhanalla dhanalla marked this pull request as draft November 21, 2025 21:25
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2025

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dhanalla
Copy link
Author

@brianjstafford, can someone from Microsoft take a look at this PR.

@openjdk
Copy link

openjdk bot commented Nov 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 21, 2025
@openjdk
Copy link

openjdk bot commented Nov 21, 2025

@dhanalla The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@dhanalla dhanalla marked this pull request as ready for review December 9, 2025 17:43
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 9, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 9, 2025

Webrevs

Copy link
Contributor

@brianjstafford brianjstafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhanalla
Copy link
Author

LGTM
Thanks @brianjstafford for reviewing this PR.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2026

@dhanalla This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@dhanalla
Copy link
Author

dhanalla commented Jan 8, 2026

@brianjstafford, could you please re‑review this PR with the latest iteration.

@dhanalla
Copy link
Author

dhanalla commented Jan 8, 2026

@theRealAph, could you please help with the review?

Copy link
Contributor

@brianjstafford brianjstafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2026

@dhanalla This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants