Skip to content

8263097: Update JMH devkit to 1.28 #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Mar 5, 2021

Currently at 1.26, so there are a few good improvements and a few bug fixes - notably resolving a build reproducibility issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2848/head:pull/2848
$ git checkout pull/2848

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 5, 2021
@openjdk
Copy link

openjdk bot commented Mar 5, 2021

@cl4es The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Mar 5, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2021

Webrevs

Copy link

@ericcaspole ericcaspole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
Eric

@erikj79
Copy link
Member

erikj79 commented Mar 5, 2021

Should also updated jib-profiles.js Oracle builds get the new version.

@cl4es
Copy link
Member Author

cl4es commented Mar 8, 2021

Uploaded and verified jib picks up the new version.

@openjdk
Copy link

openjdk bot commented Mar 8, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263097: Update JMH devkit to 1.28

Reviewed-by: ecaspole, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • ab2cfcc: 8252831: Correct "no comment" warnings in jdk.net module
  • 51cca57: 8259577: Dangling reference to temp_path in Java_sun_tools_attach_VirtualMachineImpl_getTempDir
  • a0c3f24: 8263091: Remove CharacterData.isOtherUppercase/-Lowercase
  • 13625be: 8263090: Avoid reading volatile fields twice in Locale.getDefault(Category)
  • 61cff4d: 8257913: Add more known library locations to simplify Linux cross-compilation
  • 22a3117: 8263137: Typos in sun.security.ssl.RenegoInfoExtension
  • 18fc350: 8259886: Improve SSL session cache performance and scalability
  • 3844ce4: 8261247: some compiler/whitebox/ tests fail w/ DeoptimizeALot
  • f2d0152: 8263043: Add test to verify order of tag output
  • 7182985: 8263104: fix warnings for empty paragraphs
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/d2c4ed08a2f78c22e4d59b6c29d29abf3202199d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 8, 2021
@cl4es
Copy link
Member Author

cl4es commented Mar 8, 2021

Thank you for reviewing, Eric and Erik!

/integrate

@openjdk openjdk bot closed this Mar 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2021
@openjdk
Copy link

openjdk bot commented Mar 8, 2021

@cl4es Since your change was applied there have been 38 commits pushed to the master branch:

  • ab2cfcc: 8252831: Correct "no comment" warnings in jdk.net module
  • 51cca57: 8259577: Dangling reference to temp_path in Java_sun_tools_attach_VirtualMachineImpl_getTempDir
  • a0c3f24: 8263091: Remove CharacterData.isOtherUppercase/-Lowercase
  • 13625be: 8263090: Avoid reading volatile fields twice in Locale.getDefault(Category)
  • 61cff4d: 8257913: Add more known library locations to simplify Linux cross-compilation
  • 22a3117: 8263137: Typos in sun.security.ssl.RenegoInfoExtension
  • 18fc350: 8259886: Improve SSL session cache performance and scalability
  • 3844ce4: 8261247: some compiler/whitebox/ tests fail w/ DeoptimizeALot
  • f2d0152: 8263043: Add test to verify order of tag output
  • 7182985: 8263104: fix warnings for empty paragraphs
  • ... and 28 more: https://git.openjdk.java.net/jdk/compare/d2c4ed08a2f78c22e4d59b6c29d29abf3202199d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 679faa6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@cl4es cl4es deleted the jmh_128 branch March 8, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants