Skip to content

8261247: some compiler/whitebox/ tests fail w/ DeoptimizeALot #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Mar 5, 2021

Hi all,

could you please review this small test-only patch that adds @requries vm.opt.DeoptimizeALot != true to compiler/whitebox/ tests that check if a method gets compiled? such checks can fail intermittently when are DeoptimizeALot is used (as the method can get deoptimized before we checked if it was compiled).

testing:

  • compiler/whitebox/ on macosx-x64-fastdebug w/o any flags (17 tests)
  • compiler/whitebox/ on macosx-x64-fastdebug w/ -XX:+DeoptimizeALot (6 tests)

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261247: some compiler/whitebox/ tests fail w/ DeoptimizeALot

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2849/head:pull/2849
$ git checkout pull/2849

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@iignatev iignatev marked this pull request as ready for review March 5, 2021 19:04
@iignatev
Copy link
Member Author

iignatev commented Mar 5, 2021

/label add hotspot-compiler

@iignatev iignatev marked this pull request as draft March 5, 2021 22:24
@iignatev iignatev marked this pull request as ready for review March 5, 2021 22:31
@openjdk openjdk bot added rfr Pull request is ready for review hotspot-compiler hotspot-compiler-dev@openjdk.org labels Mar 6, 2021
@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@iignatev
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 6, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good.

@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261247: some compiler/whitebox/ tests fail w/ DeoptimizeALot

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • f2d0152: 8263043: Add test to verify order of tag output
  • 7182985: 8263104: fix warnings for empty paragraphs
  • 5eb2091: 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"
  • 75a5be8: 8263054: [testbug] SharedArchiveConsistency.java reuses jsa files
  • 2afbd5d: 8250804: Can't set the application icon image for Unity WM on Linux.
  • fa43f92: 8261845: File permissions of packages built by jpackage
  • 23ee60d: 8261008: Optimize Xor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2021
@iignatev
Copy link
Member Author

iignatev commented Mar 6, 2021

thanks, Vladimir.

/integrate

@openjdk openjdk bot closed this Mar 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2021
@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@iignatev Since your change was applied there have been 7 commits pushed to the master branch:

  • f2d0152: 8263043: Add test to verify order of tag output
  • 7182985: 8263104: fix warnings for empty paragraphs
  • 5eb2091: 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"
  • 75a5be8: 8263054: [testbug] SharedArchiveConsistency.java reuses jsa files
  • 2afbd5d: 8250804: Can't set the application icon image for Unity WM on Linux.
  • fa43f92: 8261845: File permissions of packages built by jpackage
  • 23ee60d: 8261008: Optimize Xor

Your commit was automatically rebased without conflicts.

Pushed as commit 3844ce4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants