Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253421: Initialize JFR trace-IDs with zero #285

Closed
wants to merge 1 commit into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Sep 21, 2020

Currently, JFR trace-IDs for classloaders, packages and modules are initialized with 1, and the first call to atomic_inc() will update it to 2, which will be the first trace-IDs for those objects. We can initialize them to 0 and start counting at 1 instead.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/285/head:pull/285
$ git checkout pull/285

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2020

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@rkennke
Copy link
Contributor Author

@rkennke rkennke commented Sep 21, 2020

/label add jfr,hotspot,rfr

@openjdk openjdk bot added the rfr label Sep 21, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@rkennke The label jfr is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@rkennke The following label will be automatically applied to this pull request: hotspot-jfr.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-jfr label Sep 21, 2020
@rkennke
Copy link
Contributor Author

@rkennke rkennke commented Sep 21, 2020

/label add hotspot-jfr

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@rkennke The hotspot-jfr label was already applied.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2020

Webrevs

Copy link

@mgronlun mgronlun left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2020

@rkennke This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253421: Initialize JFR trace-IDs with zero

Reviewed-by: mgronlun, egahlin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 104 commits pushed to the master branch:

  • aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
  • ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
  • b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
  • 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
  • a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
  • 96f722c: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC
  • f7b1ce4: 8253447: Remove buggy code introduced by 8249451
  • 282b9dc: 8081833: Clean up JVMFlag getter/setter code
  • 0e98fc1: 8253237: [REDO] Improve large object handling during evacuation
  • d1f9b8a: 8234808: jdb quoted option parsing broken
  • ... and 94 more: https://git.openjdk.java.net/jdk/compare/68da63dcdead52418b41f80d381b105ce71a8162...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate aa3862403bf5977844e1c362494619f44ce069dc.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 21, 2020
@rkennke
Copy link
Contributor Author

@rkennke rkennke commented Sep 22, 2020

/integrate

@openjdk openjdk bot closed this Sep 22, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 22, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2020

@rkennke Since your change was applied there have been 104 commits pushed to the master branch:

  • aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
  • ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
  • b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
  • 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
  • a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
  • 96f722c: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC
  • f7b1ce4: 8253447: Remove buggy code introduced by 8249451
  • 282b9dc: 8081833: Clean up JVMFlag getter/setter code
  • 0e98fc1: 8253237: [REDO] Improve large object handling during evacuation
  • d1f9b8a: 8234808: jdb quoted option parsing broken
  • ... and 94 more: https://git.openjdk.java.net/jdk/compare/68da63dcdead52418b41f80d381b105ce71a8162...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0c287de.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr integrated
3 participants