Skip to content

JDK-8263104: fix warnings for empty paragraphs #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Mar 5, 2021

Please review some simple cleanup for empty <p> tags.

Two of the tags are completely redundant, and simply deleted.

The other three, in package.html files are generally undesirable. Although the presumed intent of the id declaration is to label the @see info, proximity in the source code does not ensure proximity in the generated code. The actual result is an empty paragraph at the end of the enclosing generated <div>, and before the generated output for the @since tag.

The better solution is to move the id declaration into the @see <a href... and then delete the empty <p>.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2850/head:pull/2850
$ git checkout pull/2850

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jonathan-gibbons
Copy link
Contributor Author

/label add core-libs

@openjdk openjdk bot added rfr Pull request is ready for review core-libs core-libs-dev@openjdk.org labels Mar 6, 2021
@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@jonathan-gibbons
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 6, 2021

Webrevs

@AlanBateman
Copy link
Contributor

/label remove core-libs
/label add security
/label add serviceability

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Mar 6, 2021
@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@AlanBateman
The core-libs label was successfully removed.

@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263104: fix warnings for empty paragraphs

Reviewed-by: alanb, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 5eb2091: 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"
  • 75a5be8: 8263054: [testbug] SharedArchiveConsistency.java reuses jsa files
  • 2afbd5d: 8250804: Can't set the application icon image for Unity WM on Linux.
  • fa43f92: 8261845: File permissions of packages built by jpackage
  • 23ee60d: 8261008: Optimize Xor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2021
@AlanBateman
Copy link
Contributor

/label add security

@AlanBateman
Copy link
Contributor

/label add serviceability

@openjdk openjdk bot added the security security-dev@openjdk.org label Mar 6, 2021
@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@AlanBateman
The security label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Mar 6, 2021
@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@AlanBateman
The serviceability label was successfully added.

@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@AlanBateman The security label was already applied.

@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@AlanBateman The serviceability label was already applied.

@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Mar 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2021
@openjdk
Copy link

openjdk bot commented Mar 6, 2021

@jonathan-gibbons Since your change was applied there have been 5 commits pushed to the master branch:

  • 5eb2091: 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button"
  • 75a5be8: 8263054: [testbug] SharedArchiveConsistency.java reuses jsa files
  • 2afbd5d: 8250804: Can't set the application icon image for Unity WM on Linux.
  • fa43f92: 8261845: File permissions of packages built by jpackage
  • 23ee60d: 8261008: Optimize Xor

Your commit was automatically rebased without conflicts.

Pushed as commit 7182985.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the empty-p branch June 30, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants