-
Notifications
You must be signed in to change notification settings - Fork 5.8k
JDK-8263104: fix warnings for empty paragraphs #2850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
/label add core-libs |
@jonathan-gibbons |
/label remove core-libs |
@AlanBateman |
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/label add security |
/label add serviceability |
@AlanBateman |
@AlanBateman |
@AlanBateman The |
@AlanBateman The |
/integrate |
@jonathan-gibbons Since your change was applied there have been 5 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7182985. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review some simple cleanup for empty
<p>
tags.Two of the tags are completely redundant, and simply deleted.
The other three, in package.html files are generally undesirable. Although the presumed intent of the
id
declaration is to label the@see
info, proximity in the source code does not ensure proximity in the generated code. The actual result is an empty paragraph at the end of the enclosing generated<div>
, and before the generated output for the@since
tag.The better solution is to move the
id
declaration into the@see <a href...
and then delete the empty<p>
.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2850/head:pull/2850
$ git checkout pull/2850