8372547: New test sun/security/provider/acvp/ML_DSA_Intrinsic_Test.java should be restricted to x86_64#28501
8372547: New test sun/security/provider/acvp/ML_DSA_Intrinsic_Test.java should be restricted to x86_64#28501ascarpino wants to merge 10 commits intoopenjdk:masterfrom
Conversation
# Conflicts: # src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp
|
👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into |
|
@ascarpino This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@ascarpino The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
dholmes-ora
left a comment
There was a problem hiding this comment.
Thanks for the quick fix.
|
/integrate |
|
Going to push as commit 46ee8d5.
Your commit was automatically rebased without conflicts. |
|
@ascarpino Pushed as commit 46ee8d5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I need a test review which prevents the second test from running on non-x64 platforms. This test was created from the recent change, ML-DSA AVX2 and AVX512 intrinsics and improvements Thanks.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28501/head:pull/28501$ git checkout pull/28501Update a local copy of the PR:
$ git checkout pull/28501$ git pull https://git.openjdk.org/jdk.git pull/28501/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28501View PR using the GUI difftool:
$ git pr show -t 28501Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28501.diff
Using Webrev
Link to Webrev Comment