8372571: ResourceHashTable for some AOT data structures miss placement operator when allocating

[tschatzl]

Hi all,

please review this cleanup adding two missing placement operators when allocating ResizeableHashTables during AOT dumping. Both table instances are clearly meant to be accessible as they are assigned to static members and accessed outside of the method creating them.

There is no problematic ResourceMark though, so there should be no current impact.

Testing: gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372571: ResourceHashTable for some AOT data structures miss placement operator when allocating (Enhancement - P4)

Reviewers

• Axel Boldt-Christmas (@xmas92 - Reviewer)
• Johan Sjölen (@jdksjolen - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28510/head:pull/28510
$ git checkout pull/28510

Update a local copy of the PR:
$ git checkout pull/28510
$ git pull https://git.openjdk.org/jdk.git pull/28510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28510

View PR using the GUI difftool:
$ git pr show -t 28510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28510.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372571: ResourceHashTable for some AOT data structures miss placement operator when allocating

Reviewed-by: aboldtch, jsjolen, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 84 new commits pushed to the master branch:

• 37d8e05: 8372708: Javadoc ignores "-locale" and uses default locale for all messages and texts
• 8d5a37b: 8371188: [s390x] Un-ProblemList TestUnreachableInnerLoop.java
• ca4ae80: 8371964: C2 compilation asserts with "Unexpected load/store size"
• ... and 81 more: https://git.openjdk.org/jdk/compare/275cb9f28799081878e0a7c53ce1c0450f4e963e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[tschatzl]

That failing test looks like a compiler issue, not related.

[mlbridge]

Webrevs

• 00: Full (a0a805d1)

[xmas92]

lgtm.

[vnkozlov]

Good.

[tschatzl]

Thanks @xmas92 @vnkozlov @jdksjolen for your reviews
/integrate

[openjdk]

Going to push as commit 2139c8c.
Since your change was applied there have been 101 commits pushed to the master branch:

• 8f3d0ad: 8371893: [macOS] use dead_strip linker option to reduce binary size
• 530493f: 8364146: JList getScrollableUnitIncrement return 0
• 1f206e5: 8372850: Update comment in SourceVersion for language evolution history for changes in 26
• ... and 98 more: https://git.openjdk.org/jdk/compare/275cb9f28799081878e0a7c53ce1c0450f4e963e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 2139c8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.