Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263051: Modernize the code in the java.awt.color package #2855

Closed
wants to merge 3 commits into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Mar 6, 2021

This is mostly the polish of the different methods in this package.

Most changes are spacing and formatting, plus code simplification. No semantic changes, mach5 is green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263051: Modernize the code in the java.awt.color package

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2855/head:pull/2855
$ git checkout pull/2855

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 6, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@mrserb
Copy link
Member Author

@mrserb mrserb commented Mar 6, 2021

/labels add 2d

Loading

@mrserb mrserb marked this pull request as ready for review Mar 6, 2021
@mrserb mrserb marked this pull request as draft Mar 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 6, 2021

@mrserb Unknown command labels - for a list of valid commands use /help.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 6, 2021

@mrserb The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the 2d label Mar 6, 2021
@mrserb mrserb marked this pull request as ready for review Mar 6, 2021
@openjdk openjdk bot added the rfr label Mar 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 6, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 8, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263051: Modernize the code in the java.awt.color package

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • ab2cfcc: 8252831: Correct "no comment" warnings in jdk.net module
  • 51cca57: 8259577: Dangling reference to temp_path in Java_sun_tools_attach_VirtualMachineImpl_getTempDir
  • a0c3f24: 8263091: Remove CharacterData.isOtherUppercase/-Lowercase
  • 13625be: 8263090: Avoid reading volatile fields twice in Locale.getDefault(Category)
  • 61cff4d: 8257913: Add more known library locations to simplify Linux cross-compilation
  • 22a3117: 8263137: Typos in sun.security.ssl.RenegoInfoExtension
  • 18fc350: 8259886: Improve SSL session cache performance and scalability
  • 3844ce4: 8261247: some compiler/whitebox/ tests fail w/ DeoptimizeALot
  • f2d0152: 8263043: Add test to verify order of tag output
  • 7182985: 8263104: fix warnings for empty paragraphs
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/718d4d487c55971c568a1d3e29f70c2fb5a11034...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Mar 8, 2021
@mrserb
Copy link
Member Author

@mrserb mrserb commented Mar 9, 2021

/integrate

Loading

@openjdk openjdk bot closed this Mar 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@mrserb Since your change was applied there have been 42 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 5bfc5fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mrserb mrserb deleted the JDK-8263051 branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants