Skip to content

Conversation

@johnshajiang
Copy link
Member

@johnshajiang johnshajiang commented Mar 7, 2021

Two typos on SCSV "signgling", which should be "signaling".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263137: Typos in sun.security.ssl.RenegoInfoExtension

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2860/head:pull/2860
$ git checkout pull/2860

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2021

👋 Welcome back jjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 7, 2021

@johnshajiang The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Mar 7, 2021
@johnshajiang johnshajiang marked this pull request as ready for review March 7, 2021 09:52
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 7, 2021

@johnshajiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263137: Typos in sun.security.ssl.RenegoInfoExtension

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2021
@johnshajiang
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Mar 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2021
@openjdk
Copy link

openjdk bot commented Mar 7, 2021

@johnshajiang Pushed as commit 22a3117.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@johnshajiang johnshajiang deleted the jdk-8263137 branch March 8, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants