8372977: unnecessary gthread-2.0 loading #28625
8372977: unnecessary gthread-2.0 loading #28625azvegint wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
|
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
I see that testing looks good. |
|
/integrate |
|
Going to push as commit 5ea2b64.
Your commit was automatically rebased without conflicts. |
Actual usage of the gthread-2.0 was removed with GTK2 support in JDK-8329471.
But there are some leftovers, we are still loading it with GTK3, even though it was never used when it was added in JDK-8164321.
It wasn't an issue before, but some modern systems (e.g. openSUSE 16) don't provide the library.
Because of this, we are unable to load GTK, which leads to Robot functionality requiring the Screencast or Remote Desktop API on Wayland not working.
Progress
Warning
8372977: unnecessary gthread-2.0 loadingIssue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28625/head:pull/28625$ git checkout pull/28625Update a local copy of the PR:
$ git checkout pull/28625$ git pull https://git.openjdk.org/jdk.git pull/28625/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28625View PR using the GUI difftool:
$ git pr show -t 28625Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28625.diff
Using Webrev
Link to Webrev Comment