Skip to content

8372977: unnecessary gthread-2.0 loading #28625

Closed
azvegint wants to merge 2 commits intoopenjdk:masterfrom
azvegint:r/8372977_unnecessary_gthread_loading
Closed

8372977: unnecessary gthread-2.0 loading #28625
azvegint wants to merge 2 commits intoopenjdk:masterfrom
azvegint:r/8372977_unnecessary_gthread_loading

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Dec 3, 2025

Actual usage of the gthread-2.0 was removed with GTK2 support in JDK-8329471.
But there are some leftovers, we are still loading it with GTK3, even though it was never used when it was added in JDK-8164321.

It wasn't an issue before, but some modern systems (e.g. openSUSE 16) don't provide the library.
Because of this, we are unable to load GTK, which leads to Robot functionality requiring the Screencast or Remote Desktop API on Wayland not working.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8372977: unnecessary gthread-2.0 loading

Issue

  • JDK-8372977: unnecessary gthread-2.0 loading (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28625/head:pull/28625
$ git checkout pull/28625

Update a local copy of the PR:
$ git checkout pull/28625
$ git pull https://git.openjdk.org/jdk.git pull/28625/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28625

View PR using the GUI difftool:
$ git pr show -t 28625

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28625.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2025

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372977: unnecessary gthread-2.0 loading

Reviewed-by: prr, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2025

Webrevs

@prrace
Copy link
Contributor

prrace commented Dec 3, 2025

I see that testing looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 3, 2025
Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@azvegint
Copy link
Member Author

azvegint commented Dec 3, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 3, 2025

Going to push as commit 5ea2b64.
Since your change was applied there have been 39 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 3, 2025
@openjdk openjdk bot closed this Dec 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2025
@openjdk
Copy link

openjdk bot commented Dec 3, 2025

@azvegint Pushed as commit 5ea2b64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants