Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8219555: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true #2864

Closed
wants to merge 2 commits into from

Conversation

@veresov
Copy link
Contributor

@veresov veresov commented Mar 7, 2021

Cleanup the behavior of the compilation policy with -Xcomp.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8219555: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2864/head:pull/2864
$ git checkout pull/2864

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 7, 2021

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 7, 2021

@veresov The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot label Mar 7, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 7, 2021

Webrevs

@veresov
Copy link
Contributor Author

@veresov veresov commented Mar 7, 2021

/label add hotspot-compiler

@openjdk
Copy link

@openjdk openjdk bot commented Mar 7, 2021

@veresov
The hotspot-compiler label was successfully added.

if (max_task != NULL && max_task->comp_level() == CompLevel_full_profile &&
TieredStopAtLevel > CompLevel_full_profile &&
max_method != NULL && is_method_profiled(max_method_h)) {
if (max_task != NULL && max_task->comp_level() == CompLevel_full_profile && TieredStopAtLevel > CompLevel_full_profile &&
Copy link
Contributor

@vnkozlov vnkozlov Mar 8, 2021

What is value of TieredStopAtLevel when Tiered is off in case you have only C2 and when you have only C1?

Copy link
Contributor Author

@veresov veresov Mar 8, 2021

The default (i.e. CompLevel_full_optimization == 4). It doesn't matter though on this particular line, because this in-queue change optimization is for CompLevel_full_profile compilation requests only, and that level is illegal with both C1-only and C2-only configuration (including when tiered is off). So, this if condition is never going to be true in these modes.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Okay.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 8, 2021

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8219555: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 8, 2021
@veresov
Copy link
Contributor Author

@veresov veresov commented Mar 8, 2021

@vnkozlov Thanks!

@veresov
Copy link
Contributor Author

@veresov veresov commented Mar 8, 2021

/integrate

@openjdk openjdk bot closed this Mar 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 8, 2021

@veresov Since your change was applied there have been 52 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 1f9ed90.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants