Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263142: Delete unused entry points in libawt/libawt_xawt/libawt_headless #2865

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Mar 7, 2021

During the review of:
8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

I have found that some of the entry points in our libraries are never used, and can be removed, we do not need to update the code to make it work in static_build.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263142: Delete unused entry points in libawt/libawt_xawt/libawt_headless

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2865/head:pull/2865
$ git checkout pull/2865

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 7, 2021

@mrserb The following labels will be automatically applied to this pull request:

  • 2d
  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added 2d client-libs-dev@openjdk.org awt client-libs-dev@openjdk.org labels Mar 7, 2021
@mrserb
Copy link
Member Author

mrserb commented Mar 7, 2021

/label remove 2d

@openjdk
Copy link

openjdk bot commented Mar 7, 2021

@mrserb Unknown command labels - for a list of valid commands use /help.

@mrserb
Copy link
Member Author

mrserb commented Mar 7, 2021

/label remove 2d

@openjdk openjdk bot removed the 2d client-libs-dev@openjdk.org label Mar 7, 2021
@openjdk
Copy link

openjdk bot commented Mar 7, 2021

@mrserb
The 2d label was successfully removed.

@mrserb mrserb marked this pull request as ready for review Mar 8, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2021

Webrevs

jobject frame, jstring jcommand)
{
}
#endif
Copy link
Member

@azuev-java azuev-java Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we do not support CDE JMF anymore? Then seems logical.

@openjdk
Copy link

openjdk bot commented Mar 8, 2021

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263142: Delete unused entry points in libawt/libawt_xawt/libawt_headless

Reviewed-by: kizune, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • b7f0b3f: 8252173: Use handles instead of jobjects in modules.cpp
  • a6e34b3: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • fbe40e8: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview
  • 0f2402d: 8263190: Update java.io, java.math, and java.text to use instanceof pattern variable
  • 4f0a12e: 8262323: do not special case JVMCI in tiered compilation policy
  • 3022baa: 8263167: IGV: build fails with "taskdef AutoUpdate cannot be found"
  • 0bc4562: 8263068: Rename safefetch.hpp to safefetch.inline.hpp
  • 5bfc5fd: 8263051: Modernize the code in the java.awt.color package
  • 5b9b170: 8262955: Unify os::fork_and_exec() across Posix platforms
  • 39b1113: 8262161: Refactor manual I/O stream copying in java.desktop to use new convenience APIs
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/22a3117d229cba10c690a4e66baf9c754a09e57c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 8, 2021
@mrserb
Copy link
Member Author

mrserb commented Mar 9, 2021

/integrate

@openjdk openjdk bot closed this Mar 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 9, 2021
@openjdk
Copy link

openjdk bot commented Mar 9, 2021

@mrserb Since your change was applied there have been 28 commits pushed to the master branch:

  • b7f0b3f: 8252173: Use handles instead of jobjects in modules.cpp
  • a6e34b3: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • fbe40e8: 8252399: Update mapMulti documentation to use type test pattern instead of instanceof once JEP 375 exits preview
  • 0f2402d: 8263190: Update java.io, java.math, and java.text to use instanceof pattern variable
  • 4f0a12e: 8262323: do not special case JVMCI in tiered compilation policy
  • 3022baa: 8263167: IGV: build fails with "taskdef AutoUpdate cannot be found"
  • 0bc4562: 8263068: Rename safefetch.hpp to safefetch.inline.hpp
  • 5bfc5fd: 8263051: Modernize the code in the java.awt.color package
  • 5b9b170: 8262955: Unify os::fork_and_exec() across Posix platforms
  • 39b1113: 8262161: Refactor manual I/O stream copying in java.desktop to use new convenience APIs
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/22a3117d229cba10c690a4e66baf9c754a09e57c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 86fac95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8263142 branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants