8373086: Make isexceeded001.java more robust#28655
8373086: Make isexceeded001.java more robust#28655albertnetymk wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ayang! A progress list of the required criteria for merging this PR into |
|
@albertnetymk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@albertnetymk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
jsikstro
left a comment
There was a problem hiding this comment.
Looks good. Interesting test bug.
|
Thanks for review. /integrate |
|
Going to push as commit 4d696d0.
Your commit was automatically rebased without conflicts. |
|
@albertnetymk Pushed as commit 4d696d0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The original intended fix is to increase initial-heap-size so avoid gc, captured in JDK-8373022. This is an alternative, which makes the test more resilient to changes in heaps/gcs.
Running
vmTestbase/nsk/monitoring/MemoryPoolMBean/isUsageThresholdExceeded/isexceeded002/TestDescription.javawith
-XX:+UseParallelGC -Xcomp -XX:-TieredCompilation -XX:InitialRAMPercentage=0fails about 10% of the time.After applying the fix,
isexceeded002passes 2,000 runs.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28655/head:pull/28655$ git checkout pull/28655Update a local copy of the PR:
$ git checkout pull/28655$ git pull https://git.openjdk.org/jdk.git pull/28655/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28655View PR using the GUI difftool:
$ git pr show -t 28655Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28655.diff
Using Webrev
Link to Webrev Comment