8373101: JdkClient and JdkServer test classes ignore namedGroups field

[mpdonova]

This PR updates a couple test utility classes, JdkClient and JdkServer. Theseclasses extend AbstractPeer which contains a namedGroup field however, when creating/configuring the objects, the field is ignored. This PR just makes sure to include named groups if they are specified.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373101: JdkClient and JdkServer test classes ignore namedGroups field (Enhancement - P4)

Reviewers

• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28664/head:pull/28664
$ git checkout pull/28664

Update a local copy of the PR:
$ git checkout pull/28664
$ git pull https://git.openjdk.org/jdk.git pull/28664/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28664

View PR using the GUI difftool:
$ git pr show -t 28664

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28664.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mdonovan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mpdonova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373101: JdkClient and JdkServer test classes ignore namedGroups field

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• b99be50: 8368524: Tests are skipped and shown as passed in test/jdk/sun/security/pkcs11/Cipher/KeyWrap
• 831fe94: 8373255: Unexpected iobj and ipdb files after JDK-8370438
• 8c8d21d: 8373295: Wrong log tag for UseCompressedOops ergo setting
• ... and 1 more: https://git.openjdk.org/jdk/compare/830c4d3b198597b6af7a21b708bd3a852af200d4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mpdonova The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a26ab92d)
• 00: Full (17d447f7)

[myankelev]

Minor: Do you think moving it outside of the if statement and making the if statement call namedGroups directly might be a bit easier to read? Otherwise you're calling the same action 3 times in a row

[myankelev]

nit: what do you think?

Suggested change

	}
	String[] namedGroupStrs = Arrays.stream(namedGroups)
	.map(NamedGroup::name)
	.toArray(String[]::new);

[mpdonova]

/integrate

[openjdk]

Going to push as commit 1ae4a6c.
Since your change was applied there have been 5 commits pushed to the master branch:

• b2daf9d: 8355522: Remove the java.locale.useOldISOCodes system property
• b99be50: 8368524: Tests are skipped and shown as passed in test/jdk/sun/security/pkcs11/Cipher/KeyWrap
• 831fe94: 8373255: Unexpected iobj and ipdb files after JDK-8370438
• ... and 2 more: https://git.openjdk.org/jdk/compare/830c4d3b198597b6af7a21b708bd3a852af200d4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mpdonova Pushed as commit 1ae4a6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.