Skip to content

8373113: Fix whitespace in RunTests.gmk#28668

Closed
erikj79 wants to merge 1 commit intoopenjdk:masterfrom
erikj79:JDK-8373113-whitespace
Closed

8373113: Fix whitespace in RunTests.gmk#28668
erikj79 wants to merge 1 commit intoopenjdk:masterfrom
erikj79:JDK-8373113-whitespace

Conversation

@erikj79
Copy link
Member

@erikj79 erikj79 commented Dec 4, 2025

While reading RunTests.gmk recently I found several instances of bad whitespace usage, tabs vs spaces. Correct usage of tabs is important in makefiles and even if none of these are particularly severe on their own, they can compound with other mistakes to create very hard to debug problems.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373113: Fix whitespace in RunTests.gmk (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28668/head:pull/28668
$ git checkout pull/28668

Update a local copy of the PR:
$ git checkout pull/28668
$ git pull https://git.openjdk.org/jdk.git pull/28668/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28668

View PR using the GUI difftool:
$ git pr show -t 28668

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28668.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2025

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2025

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373113: Fix whitespace in RunTests.gmk

Reviewed-by: tbell

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8373113 8373113: Fix whitespace in RunTests.gmk Dec 4, 2025
@openjdk openjdk bot added the build build-dev@openjdk.org label Dec 4, 2025
@openjdk
Copy link

openjdk bot commented Dec 4, 2025

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2025

Webrevs

Copy link
Member

@tbell29552 tbell29552 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2025
@erikj79
Copy link
Member Author

erikj79 commented Dec 5, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 5, 2025

Going to push as commit c09167d.
Since your change was applied there have been 53 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2025
@openjdk openjdk bot closed this Dec 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 5, 2025
@openjdk
Copy link

openjdk bot commented Dec 5, 2025

@erikj79 Pushed as commit c09167d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants