8263167: IGV: build fails with "taskdef AutoUpdate cannot be found"

[robcasloz]

As part of the recent transition of the NetBeans project to the Apache fundation, http://bits.netbeans.org has stopped serving the tasks.jar file used to download IGV's build dependencies. This change updates the IGV build configuration to use the nbm-maven-harness Maven artifact instead, which provides the same functionality.

Tested manually on linux-x64.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8263167: IGV: build fails with "taskdef AutoUpdate cannot be found"

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Richard Reingruber (@reinrich - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2869/head:pull/2869
$ git checkout pull/2869

[bridgekeeper]

👋 Welcome back rcastanedalo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robcasloz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b0c03c4)

[chhagedorn]

Looks good! On my machine, I first had to delete the old tasks.jar in order to build again:

$ ant build
Buildfile: /home/christian/valhalla/open/src/utils/IdealGraphVisualizer/build.xml

download:
     [echo] Downloading clusters ide|platform
      [get] Getting: https://repo.maven.apache.org/maven2/org/codehaus/mojo/nbm-maven-harness/7.4/nbm-maven-harness-7.4.jar
      [get] To: /tmp/tasks.jar
      [get] local file date : Fri Mar 05 06:41:46 CET 2021
      [get] Not modified - so not downloaded

BUILD FAILED
/home/christian/valhalla/open/src/utils/IdealGraphVisualizer/build.xml:7: The following error occurred while executing this line:
/home/christian/valhalla/open/src/utils/IdealGraphVisualizer/nbproject/build-impl.xml:41: The following error occurred while executing this line:
/home/christian/valhalla/open/src/utils/IdealGraphVisualizer/nbproject/platform.xml:28: taskdef class org.netbeans.nbbuild.AutoUpdate cannot be found
 using the classloader AntClassLoader[/tmp/tasks.jar]

$ rm /tmp/tasks.jar
$ ant build
....
BUILD SUCCESSFUL
Total time: 3 minutes 53 seconds

After deleting /tmp/tasks.jar, it took some time to download everything but the build worked again.

[openjdk]

@robcasloz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263167: IGV: build fails with "taskdef AutoUpdate cannot be found"

Update IGV build configuration to use the nbm-maven-harness Maven artifact.

Reviewed-by: chagedorn, rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 0bc4562: 8263068: Rename safefetch.hpp to safefetch.inline.hpp
• 5bfc5fd: 8263051: Modernize the code in the java.awt.color package
• 5b9b170: 8262955: Unify os::fork_and_exec() across Posix platforms
• 39b1113: 8262161: Refactor manual I/O stream copying in java.desktop to use new convenience APIs
• 4e94760: 8263135: unique_ptr should not be used for types that are not pointers
• f71b21b: 8263038: Optimize String.format for simple specifiers
• 14cfbda: 8261366: Add discussion of IEEE 754 to BigDecimal
• 414ee95: 8261462: GCM ByteBuffer decryption problems
• eb4a8af: 8260664: Phaser.arrive() memory consistency effects
• 9221540: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest
• ... and 12 more: https://git.openjdk.java.net/jdk/compare/22a3117d229cba10c690a4e66baf9c754a09e57c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[robcasloz]

Looks good!

Thanks for reviewing, Christian!

On my machine, I first had to delete the old tasks.jar in order to build again:

Thanks, I made a comment about that in the JBS report.

[reinrich]

Looks good. I've tested the change on Linux x86_64. I also had to remove /tmp/tasks.jar but then the build succeeded.

Thanks for fixing!

[robcasloz]

Looks good. I've tested the change on Linux x86_64. I also had to remove /tmp/tasks.jar but then the build succeeded.

Thanks for fixing!

Thanks for reviewing, Richard.

[robcasloz]

/summary
Update IGV build configuration to use the nbm-maven-harness Maven artifact.

[openjdk]

@robcasloz Setting summary to Update IGV build configuration to use the nbm-maven-harness Maven artifact.

[robcasloz]

/integrate

[openjdk]

@robcasloz Since your change was applied there have been 22 commits pushed to the master branch:

• 0bc4562: 8263068: Rename safefetch.hpp to safefetch.inline.hpp
• 5bfc5fd: 8263051: Modernize the code in the java.awt.color package
• 5b9b170: 8262955: Unify os::fork_and_exec() across Posix platforms
• 39b1113: 8262161: Refactor manual I/O stream copying in java.desktop to use new convenience APIs
• 4e94760: 8263135: unique_ptr should not be used for types that are not pointers
• f71b21b: 8263038: Optimize String.format for simple specifiers
• 14cfbda: 8261366: Add discussion of IEEE 754 to BigDecimal
• 414ee95: 8261462: GCM ByteBuffer decryption problems
• eb4a8af: 8260664: Phaser.arrive() memory consistency effects
• 9221540: 8213269: convert test/hotspot/jtreg/runtime/memory/RunUnitTestsConcurrently to gtest
• ... and 12 more: https://git.openjdk.java.net/jdk/compare/22a3117d229cba10c690a4e66baf9c754a09e57c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3022baa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.