8373231: ECDSAOperations::toAffinePoint is redundant

[johnshajiang]

ECDSAOperations::toAffinePoint should be removed, and AffinePoint::fromECPoint should be used instead.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373231: ECDSAOperations::toAffinePoint is redundant (Bug - P4)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28691/head:pull/28691
$ git checkout pull/28691

Update a local copy of the PR:
$ git checkout pull/28691
$ git pull https://git.openjdk.org/jdk.git pull/28691/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28691

View PR using the GUI difftool:
$ git pr show -t 28691

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28691.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@johnshajiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373231: ECDSAOperations::toAffinePoint is redundant

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 327 new commits pushed to the master branch:

• 6d1bfdf: 8374796: CompressedOops versions of runtime/cds/TestDefaultArchiveLoading.java aren't run
• 47e1935: 8373941: Epsilon: Robust counter updates in early VM phases
• c8c6e70: 8374825: vmTestbase comment typo: lunch
• ... and 324 more: https://git.openjdk.org/jdk/compare/5f083abafc7abfaa46ddd053668cdfbfd2ad8a87...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@johnshajiang The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a1cebba7)
• 01: Full - Incremental (1837abec)
• 00: Full (a1cebba7)

[myankelev]

Correct me if I'm wrong, this seems to be changing public API, shouldn't it have a csr then?

[myankelev]

Could you please update the bug id?

[seanjmullan]

Correct me if I'm wrong, this seems to be changing public API, shouldn't it have a csr then?

It's a class in an internal package (sun.security.ec), so should not need a CSR.

[seanjmullan]

You are not testing something new here, so you should not add the bugid.

[johnshajiang]

Just withdrew the last commit.

[openjdk]

@johnshajiang Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[johnshajiang]

/integrate

[openjdk]

Going to push as commit a726e83.
Since your change was applied there have been 332 commits pushed to the master branch:

• 74faf03: 8374819: jpackage and jpackage tests leave some I/O streams unclosed
• 805866b: 8372040: Remove Prefetch header vs inline header separation
• 663a083: 8374219: Fix issues in jpackage's Executor class
• ... and 329 more: https://git.openjdk.org/jdk/compare/5f083abafc7abfaa46ddd053668cdfbfd2ad8a87...master

Your commit was automatically rebased without conflicts.

[openjdk]

@johnshajiang Pushed as commit a726e83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.