8371920: [TEST] Enable CMove tests on other platforms

[Hamlin-Li]

Hi,
Can you help to review this patch?

JDK-8357551 add support of CMoveF/D vectorization, at the same time it also adds some tests for scalar CMove on riscv.
It's good to enable these tests on other platforms, like x86/aarch64 or maybe others.

At the same time, this pr also move these tests under compiler/c2/cmove, as suggested here #28309 (comment).

Thanks!

Test

In progress... (I'm using github CI to run the tests.)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371920: [TEST] Enable CMove tests on other platforms (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Emanuel Peter (@eme64 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28702/head:pull/28702
$ git checkout pull/28702

Update a local copy of the PR:
$ git checkout pull/28702
$ git pull https://git.openjdk.org/jdk.git pull/28702/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28702

View PR using the GUI difftool:
$ git pr show -t 28702

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28702.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371920: [TEST] Enable CMove tests on other platforms

Reviewed-by: fyang, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 6a6ff87: 8372860: TestCodeCacheUnloadDuringConcCycle fails on ARM32
• 4b774cb: 8370489: Some compiler tests miss the @key randomness
• b46aef8: 8371871: libSharedCloseAgent.cpp crashes VS2019 and older VS2022 compiler
• ... and 46 more: https://git.openjdk.org/jdk/compare/6700baa5052046f53eb1b04ed3205bbd8e9e9070...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (48c99a81)
• 01: Full - Incremental (7848a1bf)
• 00: Full (c901dece)

[eme64]

@Hamlin-Li Thanks for publishing this so quickly, and for considering other platforms, much appreciated 😊

The patch looks good to me.
I'll run some internal testing now.

[RealFYang]

Latest version LGTM.

[Hamlin-Li]

Latest version LGTM.

@RealFYang Thank you!

[Hamlin-Li]

@eme64 Is this pr good to go?
BTW, for the pure test change, is only one approval sufficient or not?

[eme64]

@Hamlin-Li Thanks for the updates! Still looks good to me.

[Hamlin-Li]

@Hamlin-Li Thanks for the updates! Still looks good to me.

@eme64 Thank you!

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit dc62552.
Since your change was applied there have been 60 commits pushed to the master branch:

• 650de99: 8367158: C2: create better fill and copy benchmarks, taking alignment into account
• 325cdb7: 8373517: Revert the macos Tahoe specific change done in JDK-8359830
• c46bed7: 8371502: serviceability/jvmti/vthread/ThreadListStackTracesTest/ThreadListStackTracesTest.java failing
• ... and 57 more: https://git.openjdk.org/jdk/compare/6700baa5052046f53eb1b04ed3205bbd8e9e9070...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit dc62552.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.