8371718: (sc) Channels.new{Input,Output}Stream can allocate unbounded memory for a socket channel

[bplb]

Clamp read and write to 128k bytes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371718: (sc) Channels.new{Input,Output}Stream can allocate unbounded memory for a socket channel (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28705/head:pull/28705
$ git checkout pull/28705

Update a local copy of the PR:
$ git checkout pull/28705
$ git pull https://git.openjdk.org/jdk.git pull/28705/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28705

View PR using the GUI difftool:
$ git pr show -t 28705

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28705.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371718: (sc) Channels.new{Input,Output}Stream can allocate unbounded memory for a socket channel

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 1bbbce7: 6726690: SwingUtilities.replaceUI*Map() methods do not remove previously installed maps
• a5968f9: 8371968: RISC-V: implement AES CBC intrinsics
• d36a234: 8368701: CDS VerifierTest_1A.java failed on machines with 512 GB RAM
• ... and 28 more: https://git.openjdk.org/jdk/compare/811591c5c332e6427dc96819451e046841fe635b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 06: Full - Incremental (e8036cf8)
• 05: Full - Incremental (6f2e8568)
• 04: Full - Incremental (956d64b2)
• 03: Full - Incremental (3f2983ad)
• 02: Full - Incremental (1e7aefd9)
• 01: Full - Incremental (3aa2f796)
• 00: Full (113a430d)

[bplb]

/integrate

[openjdk]

Going to push as commit 74dca86.
Since your change was applied there have been 40 commits pushed to the master branch:

• 52aa7fe: 8334549: [Sound] Test timed out: javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java
• 413f852: 8369736: Add management interface for AOT cache creation
• 11aa6e1: 8373270: GCC 14.2.0 reports warning: '%s' directive output may be truncated
• ... and 37 more: https://git.openjdk.org/jdk/compare/811591c5c332e6427dc96819451e046841fe635b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 74dca86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.