8373270: GCC 14.2.0 reports warning: '%s' directive output may be truncated

[fmatte1]

8373270: GCC 14.2.0 reports warning: '%s' directive output may be truncated

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373270: GCC 14.2.0 reports warning: '%s' directive output may be truncated (Bug - P4)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28708/head:pull/28708
$ git checkout pull/28708

Update a local copy of the PR:
$ git checkout pull/28708
$ git pull https://git.openjdk.org/jdk.git pull/28708/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28708

View PR using the GUI difftool:
$ git pr show -t 28708

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28708.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fmatte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fmatte1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373270: GCC 14.2.0 reports warning: '%s' directive output may be truncated

Reviewed-by: kbarrett, dholmes, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• b60ac71: 8364490: Fatal error on large SpecTrapLimitExtraEntries value
• 00068a8: 8354282: C2: more crashes in compiled code because of dependency on removed range check CastIIs
• 1bbbce7: 6726690: SwingUtilities.replaceUI*Map() methods do not remove previously installed maps
• ... and 29 more: https://git.openjdk.org/jdk/compare/d34ef196c298aa91f8511714cfb04b15ae7fbf0a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@fmatte1 The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (0f80a1fa)
• 02: Full - Incremental (1fe110f4)
• 01: Full - Incremental (046e8181)
• 00: Full (2a9daf8b)

[kimbarrett]

Why not just delete this no longer used function?

[fmatte1]

Thanks Kim for looking into it, yes we can remove this, I wasn't sure why this was kept and not removed. Removing is good, as this was unused since JDK 9 times.

[sendaoYan]

Do we need update the copyright year.

[fmatte1]

Do we need update the copyright year.

I am not sure, this is just a trivial cleanup change.

[kimbarrett]

Do we need update the copyright year.

I am not sure, this is just a trivial cleanup change.

I think you should update the copyright year.

[kimbarrett]

Looks good.

[fmatte1]

Do we need update the copyright year.

I am not sure, this is just a trivial cleanup change.

I think you should update the copyright year.

I have updated the copyright year! Thanks,

[dholmes-ora]

Looks good.

FTR we always update the copyright year, regardless of the size of the change to the file.

Thanks

[AlanBateman]

Looks okay, maybe consider renaming the JBS issue to make it clear that this is just removing unused code.

[fmatte1]

@kimbarrett @dholmes-ora and @AlanBateman thanks for the reviews, I have updated the JBS issue to reflect the change.

/integrate

[openjdk]

Going to push as commit 11aa6e1.
Since your change was applied there have been 36 commits pushed to the master branch:

• 54430a8: 8373362: Http3TestServer should not log an exception stack trace when it is stopping normally
• 655e9cd: 8373335: Serial: Clean up SerialHeap members by access specifies
• b58e3b6: 8373227: Test java/net/httpclient/http2/StreamFlowControlTest.java failed: should sleep time be raised?
• ... and 33 more: https://git.openjdk.org/jdk/compare/d34ef196c298aa91f8511714cfb04b15ae7fbf0a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fmatte1 Pushed as commit 11aa6e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.