8373255: Unexpected iobj and ipdb files after JDK-8370438#28709
8373255: Unexpected iobj and ipdb files after JDK-8370438#28709erikj79 wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back erikj! A progress list of the required criteria for merging this PR into |
|
@erikj79 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Is it possible that this issue is similar to #28712 ? |
mrserb
left a comment
There was a problem hiding this comment.
I confirm that it fixes the issue.
|
Yes it does appear that this is what is breaking the cmp-baselines build on Windows. |
|
This should indeed fix the cmp-baseline build on Windows. I had missed that issue, sorry about that. I'm running a full builds tier1-5 on this branch (where the revert has not happened) to confirm. |
|
Confirmed that this fixes the cmp-baseline issue as well, so you can re-enable LTO for splashscreen if you wish. |
|
/integrate |
|
Going to push as commit 831fe94.
Your commit was automatically rebased without conflicts. |
|
/backport :jdk26 |
|
@erikj79 the backport was successfully created on the branch backport-erikj79-831fe94c-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk: |
When using
-LTCGwith Visual Studio, then by default, the linker will output an extra.iobjfile in the same directory as the target file. In the OpenJDK build that means this file, along with the accompanying.ipdbfile, will end up in the JDK image. To fix this, we need to apply a similar fix to JDK-8372643 and add an extra parameter that defines the location of this file.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28709/head:pull/28709$ git checkout pull/28709Update a local copy of the PR:
$ git checkout pull/28709$ git pull https://git.openjdk.org/jdk.git pull/28709/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28709View PR using the GUI difftool:
$ git pr show -t 28709Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28709.diff
Using Webrev
Link to Webrev Comment