Skip to content

8373255: Unexpected iobj and ipdb files after JDK-8370438#28709

Closed
erikj79 wants to merge 2 commits intoopenjdk:masterfrom
erikj79:JDK-8373255-iobj
Closed

8373255: Unexpected iobj and ipdb files after JDK-8370438#28709
erikj79 wants to merge 2 commits intoopenjdk:masterfrom
erikj79:JDK-8373255-iobj

Conversation

@erikj79
Copy link
Member

@erikj79 erikj79 commented Dec 8, 2025

When using -LTCG with Visual Studio, then by default, the linker will output an extra .iobj file in the same directory as the target file. In the OpenJDK build that means this file, along with the accompanying .ipdb file, will end up in the JDK image. To fix this, we need to apply a similar fix to JDK-8372643 and add an extra parameter that defines the location of this file.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373255: Unexpected iobj and ipdb files after JDK-8370438 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28709/head:pull/28709
$ git checkout pull/28709

Update a local copy of the PR:
$ git checkout pull/28709
$ git pull https://git.openjdk.org/jdk.git pull/28709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28709

View PR using the GUI difftool:
$ git pr show -t 28709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28709.diff

Using Webrev

Link to Webrev Comment

@erikj79 erikj79 marked this pull request as ready for review December 8, 2025 23:37
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2025

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373255: Unexpected iobj and ipdb files after JDK-8370438

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8373255 8373255: Unexpected iobj and ipdb files after JDK-8370438 Dec 8, 2025
@openjdk openjdk bot added the build build-dev@openjdk.org label Dec 8, 2025
@openjdk
Copy link

openjdk bot commented Dec 8, 2025

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2025

Webrevs

@mrserb
Copy link
Member

mrserb commented Dec 9, 2025

Is it possible that this issue is similar to #28712 ?

Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it fixes the issue.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2025
@mrserb
Copy link
Member

mrserb commented Dec 9, 2025

Is it possible that this issue is similar to #28712 ?

Seems so. Could you please confirm this with the full test set in mach5? It is not necessary to revert "that revert" until #28676 is fixed, but it would be good to know that the issue on windows is resolved.

@dholmes-ora
Copy link
Member

Yes it does appear that this is what is breaking the cmp-baselines build on Windows.

@erikj79
Copy link
Member Author

erikj79 commented Dec 9, 2025

This should indeed fix the cmp-baseline build on Windows. I had missed that issue, sorry about that. I'm running a full builds tier1-5 on this branch (where the revert has not happened) to confirm.

@erikj79
Copy link
Member Author

erikj79 commented Dec 9, 2025

Confirmed that this fixes the cmp-baseline issue as well, so you can re-enable LTO for splashscreen if you wish.

@erikj79
Copy link
Member Author

erikj79 commented Dec 9, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 9, 2025

Going to push as commit 831fe94.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 9, 2025
@openjdk openjdk bot closed this Dec 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2025
@openjdk
Copy link

openjdk bot commented Dec 9, 2025

@erikj79 Pushed as commit 831fe94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@erikj79
Copy link
Member Author

erikj79 commented Dec 9, 2025

/backport :jdk26

@openjdk
Copy link

openjdk bot commented Dec 9, 2025

@erikj79 the backport was successfully created on the branch backport-erikj79-831fe94c-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 831fe94c from the openjdk/jdk repository.

The commit being backported was authored by Erik Joelsson on 9 Dec 2025 and was reviewed by Sergey Bylokhov.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-erikj79-831fe94c-jdk26:backport-erikj79-831fe94c-jdk26
$ git checkout backport-erikj79-831fe94c-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-erikj79-831fe94c-jdk26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants