8198317: Enhance JavacTool.getTask for flexibility #2871

lahodaj · 2021-03-08T11:21:38Z

This is a clone of #1896, which got closed by Skara.

@lgxbslgx, please let me know if you would prefer to resubmit the PR yourself.

/contributor add lgxbslgx

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8198317: Enhance JavacTool.getTask for flexibility

Reviewers

Joel Borggrén-Franck (@jbf - Reviewer) ⚠️ Review applies to ec3c892

Contributors

Guoxiong Li <lgxbslgx@gmail.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2871/head:pull/2871
$ git checkout pull/2871

Update a local copy of the PR:
$ git checkout pull/2871
$ git pull https://git.openjdk.java.net/jdk pull/2871/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2871

View PR using the GUI difftool:
$ git pr show -t 2871

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2871.diff

bridgekeeper · 2021-03-08T11:21:48Z

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-03-08T11:23:00Z

@lahodaj Could not parse lgxbslgx as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

lahodaj · 2021-03-08T11:23:08Z

/contributor add @lgxbslgx

openjdk · 2021-03-08T11:23:30Z

@lahodaj The following label will be automatically applied to this pull request:

compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk · 2021-03-08T11:23:40Z

@lahodaj Could not parse @lgxbslgx as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

/contributor add @openjdk-bot
/contributor add duke
/contributor add J. Duke <duke@openjdk.org>

mlbridge · 2021-03-08T11:26:24Z

Webrevs

liach · 2021-03-09T01:24:24Z

test/langtools/tools/javac/api/8198317/T8198317.java

+import toolbox.TestRunner;
+import static toolbox.ToolBox.lineSeparator;
+
+public class T8198317 extends TestRunner{


jonathan-gibbons · 2021-03-09T05:23:21Z

test/langtools/tools/javac/api/8198317/T8198317.java

+import toolbox.TestRunner;
+import static toolbox.ToolBox.lineSeparator;
+
+public class T8198317 extends TestRunner{


These days, it is considered bad form to base a test name on a bug number. It's better to come up with a meaningful name for the test. That probably applies to the enclosing directory as well.

lahodaj · 2021-03-15T09:22:05Z

/contributor add Guoxiong Li lgxbslgx@gmail.com

openjdk · 2021-03-15T09:22:31Z

@lahodaj
Contributor Guoxiong Li <lgxbslgx@gmail.com> successfully added.

lgxbslgx · 2021-04-06T05:19:43Z

@lahodaj It is good for me to continue the work in this PR. I will assist you if you need.

lgxbslgx

The original patch began at Dec 2020. About four months passed. Could somebody help me push this patch? Thanks a lot.

lgxbslgx · 2021-04-22T09:41:58Z

test/langtools/tools/javac/api/TestContextLoggingOutput.java

@@ -0,0 +1,126 @@
+/*
+ * Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.


The copyright should be updated to 2021.

jbf · 2021-04-28T10:38:13Z

src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTool.java

                context.put(Log.errKey, new PrintWriter(System.err, true));
-            else
+            else if (out instanceof PrintWriter)


Can use instance of pattern matching

jbf

Looks good to me

openjdk · 2021-04-28T10:50:49Z

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8198317: Enhance JavacTool.getTask for flexibility

Co-authored-by: Guoxiong Li <lgxbslgx@gmail.com>
Reviewed-by: jfranck

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1763 new commits pushed to the master branch:

39abac9: 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c
155da25: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible
91226fa: 8265940: Enable C2's optimization for Math.pow(x, 0.5) on all platforms
56cde70: 8266265: mark hotspot compiler/vectorization tests which ignore VM flags
4937214: 8266174: -Wmisleading-indentation happens in libmlib_image sources
b305eff: 8266238: mark hotspot compiler/inlining tests which ignore VM flags
df3b2d0: 8266264: mark hotspot compiler/eliminateAutobox tests which ignore VM flags
6b263e6: 8266256: compiler.vectorization.TestBufferVectorization does testing twice
69155f4: 8266231: mark hotspot compiler/c1 tests which ignore VM flags
0e225ef: 8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows
... and 1753 more: https://git.openjdk.java.net/jdk/compare/b575dd80b6e86821fcf3e065e31c6bddb85db6c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

lahodaj · 2021-04-29T09:37:04Z

/integrate

openjdk · 2021-04-29T09:38:46Z

@lahodaj Since your change was applied there have been 1764 commits pushed to the master branch:

115a413: 8265123: Add static factory methods to com.sun.net.httpserver.Filter
39abac9: 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c
155da25: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible
91226fa: 8265940: Enable C2's optimization for Math.pow(x, 0.5) on all platforms
56cde70: 8266265: mark hotspot compiler/vectorization tests which ignore VM flags
4937214: 8266174: -Wmisleading-indentation happens in libmlib_image sources
b305eff: 8266238: mark hotspot compiler/inlining tests which ignore VM flags
df3b2d0: 8266264: mark hotspot compiler/eliminateAutobox tests which ignore VM flags
6b263e6: 8266256: compiler.vectorization.TestBufferVectorization does testing twice
69155f4: 8266231: mark hotspot compiler/c1 tests which ignore VM flags
... and 1754 more: https://git.openjdk.java.net/jdk/compare/b575dd80b6e86821fcf3e065e31c6bddb85db6c4...master

Your commit was automatically rebased without conflicts.

Pushed as commit df7f0b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

lgxbslgx added 4 commits December 25, 2020 20:31

8198317: Enhance JavacTool.getTask for flexibility

5ac98f7

Add a test case.

f73c405

Revise test.

e13c072

Revise test code. Fix typo.

909140e

openjdk bot added the rfr Pull request is ready for review label Mar 8, 2021

openjdk bot added the compiler compiler-dev@openjdk.org label Mar 8, 2021

liach reviewed Mar 9, 2021

View reviewed changes

jonathan-gibbons suggested changes Mar 9, 2021

View reviewed changes

Updating test per review comments.

ec3c892

lgxbslgx reviewed Apr 22, 2021

View reviewed changes

jbf reviewed Apr 28, 2021

View reviewed changes

jbf approved these changes Apr 28, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 28, 2021

Reflecting review comments.

3ed19b9

openjdk bot closed this Apr 29, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8198317: Enhance JavacTool.getTask for flexibility #2871

8198317: Enhance JavacTool.getTask for flexibility #2871

lahodaj commented Mar 8, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 8, 2021

openjdk bot commented Mar 8, 2021

lahodaj commented Mar 8, 2021

openjdk bot commented Mar 8, 2021

openjdk bot commented Mar 8, 2021

mlbridge bot commented Mar 8, 2021 •

edited

Loading

liach Mar 9, 2021

jonathan-gibbons Mar 9, 2021

lahodaj commented Mar 15, 2021

openjdk bot commented Mar 15, 2021

lgxbslgx commented Apr 6, 2021

lgxbslgx left a comment

lgxbslgx Apr 22, 2021

jbf Apr 28, 2021

jbf left a comment

openjdk bot commented Apr 28, 2021 •

edited

Loading

lahodaj commented Apr 29, 2021

openjdk bot commented Apr 29, 2021

		@@ -0,0 +1,126 @@
		/*
		* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.

8198317: Enhance JavacTool.getTask for flexibility #2871

8198317: Enhance JavacTool.getTask for flexibility #2871

Conversation

lahodaj commented Mar 8, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Contributors

Reviewing

bridgekeeper bot commented Mar 8, 2021

openjdk bot commented Mar 8, 2021

lahodaj commented Mar 8, 2021

openjdk bot commented Mar 8, 2021

openjdk bot commented Mar 8, 2021

mlbridge bot commented Mar 8, 2021 • edited Loading

Webrevs

liach Mar 9, 2021

Choose a reason for hiding this comment

jonathan-gibbons Mar 9, 2021

Choose a reason for hiding this comment

lahodaj commented Mar 15, 2021

openjdk bot commented Mar 15, 2021

lgxbslgx commented Apr 6, 2021

lgxbslgx left a comment

Choose a reason for hiding this comment

lgxbslgx Apr 22, 2021

Choose a reason for hiding this comment

jbf Apr 28, 2021

Choose a reason for hiding this comment

jbf left a comment

Choose a reason for hiding this comment

openjdk bot commented Apr 28, 2021 • edited Loading

lahodaj commented Apr 29, 2021

openjdk bot commented Apr 29, 2021

lahodaj commented Mar 8, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 8, 2021 •

edited

Loading

openjdk bot commented Apr 28, 2021 •

edited

Loading