Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8198317: Enhance JavacTool.getTask for flexibility #2871

Closed
wants to merge 6 commits into from

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Mar 8, 2021

This is a clone of #1896, which got closed by Skara.

@lgxbslgx, please let me know if you would prefer to resubmit the PR yourself.

/contributor add lgxbslgx


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8198317: Enhance JavacTool.getTask for flexibility

Reviewers

Contributors

  • Guoxiong Li <lgxbslgx@gmail.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/2871/head:pull/2871
$ git checkout pull/2871

Update a local copy of the PR:
$ git checkout pull/2871
$ git pull https://git.openjdk.java.net/jdk pull/2871/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2871

View PR using the GUI difftool:
$ git pr show -t 2871

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/2871.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 8, 2021

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Mar 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 8, 2021

@lahodaj Could not parse lgxbslgx as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

Loading

@lahodaj
Copy link
Contributor Author

@lahodaj lahodaj commented Mar 8, 2021

/contributor add @lgxbslgx

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 8, 2021

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the compiler label Mar 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 8, 2021

@lahodaj Could not parse @lgxbslgx as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 8, 2021

Webrevs

Loading

import toolbox.TestRunner;
import static toolbox.ToolBox.lineSeparator;

public class T8198317 extends TestRunner{
Copy link
Contributor

@liach liach Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting

Loading

import toolbox.TestRunner;
import static toolbox.ToolBox.lineSeparator;

public class T8198317 extends TestRunner{
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These days, it is considered bad form to base a test name on a bug number. It's better to come up with a meaningful name for the test. That probably applies to the enclosing directory as well.

Loading

@lahodaj
Copy link
Contributor Author

@lahodaj lahodaj commented Mar 15, 2021

/contributor add Guoxiong Li lgxbslgx@gmail.com

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@lahodaj
Contributor Guoxiong Li <lgxbslgx@gmail.com> successfully added.

Loading

@lgxbslgx
Copy link
Member

@lgxbslgx lgxbslgx commented Apr 6, 2021

@lahodaj It is good for me to continue the work in this PR. I will assist you if you need.

Loading

Copy link
Member

@lgxbslgx lgxbslgx left a comment

The original patch began at Dec 2020. About four months passed. Could somebody help me push this patch? Thanks a lot.

Loading

@@ -0,0 +1,126 @@
/*
* Copyright (c) 2020, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

@lgxbslgx lgxbslgx Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright should be updated to 2021.

Loading

context.put(Log.errKey, new PrintWriter(System.err, true));
else
else if (out instanceof PrintWriter)
Copy link
Member

@jbf jbf Apr 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use instance of pattern matching

Loading

jbf
jbf approved these changes Apr 28, 2021
Copy link
Member

@jbf jbf left a comment

Looks good to me

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2021

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8198317: Enhance JavacTool.getTask for flexibility

Co-authored-by: Guoxiong Li <lgxbslgx@gmail.com>
Reviewed-by: jfranck

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1763 new commits pushed to the master branch:

  • 39abac9: 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c
  • 155da25: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible
  • 91226fa: 8265940: Enable C2's optimization for Math.pow(x, 0.5) on all platforms
  • 56cde70: 8266265: mark hotspot compiler/vectorization tests which ignore VM flags
  • 4937214: 8266174: -Wmisleading-indentation happens in libmlib_image sources
  • b305eff: 8266238: mark hotspot compiler/inlining tests which ignore VM flags
  • df3b2d0: 8266264: mark hotspot compiler/eliminateAutobox tests which ignore VM flags
  • 6b263e6: 8266256: compiler.vectorization.TestBufferVectorization does testing twice
  • 69155f4: 8266231: mark hotspot compiler/c1 tests which ignore VM flags
  • 0e225ef: 8197821: Test java/awt/font/TextLayout/LigatureCaretTest.java fails on Windows
  • ... and 1753 more: https://git.openjdk.java.net/jdk/compare/b575dd80b6e86821fcf3e065e31c6bddb85db6c4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 28, 2021
@lahodaj
Copy link
Contributor Author

@lahodaj lahodaj commented Apr 29, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@lahodaj Since your change was applied there have been 1764 commits pushed to the master branch:

  • 115a413: 8265123: Add static factory methods to com.sun.net.httpserver.Filter
  • 39abac9: 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c
  • 155da25: 8265005: Introduce the new client property for mac: apple.awt.windowTitleVisible
  • 91226fa: 8265940: Enable C2's optimization for Math.pow(x, 0.5) on all platforms
  • 56cde70: 8266265: mark hotspot compiler/vectorization tests which ignore VM flags
  • 4937214: 8266174: -Wmisleading-indentation happens in libmlib_image sources
  • b305eff: 8266238: mark hotspot compiler/inlining tests which ignore VM flags
  • df3b2d0: 8266264: mark hotspot compiler/eliminateAutobox tests which ignore VM flags
  • 6b263e6: 8266256: compiler.vectorization.TestBufferVectorization does testing twice
  • 69155f4: 8266231: mark hotspot compiler/c1 tests which ignore VM flags
  • ... and 1754 more: https://git.openjdk.java.net/jdk/compare/b575dd80b6e86821fcf3e065e31c6bddb85db6c4...master

Your commit was automatically rebased without conflicts.

Pushed as commit df7f0b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants