8373335: Serial: Clean up SerialHeap members by access specifies

[albertnetymk]

Trivial moving member of SerialHeap so that all private fields/methods are altogether (at the top).

Test: tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373335: Serial: Clean up SerialHeap members by access specifies (Enhancement - P4)

Reviewers

• Joel Sikström (@jsikstro - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28718/head:pull/28718
$ git checkout pull/28718

Update a local copy of the PR:
$ git checkout pull/28718
$ git pull https://git.openjdk.org/jdk.git pull/28718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28718

View PR using the GUI difftool:
$ git pr show -t 28718

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28718.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373335: Serial: Clean up SerialHeap members by access specifies

Reviewed-by: jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 830c4d3: 8366272: The os::xxx APIs do not manage errno correctly
• 0a55789: 8373025: test/hotspot/jtreg/gc/cslocker/TestCSLocker.java may deadlock
• 1f49edd: 4459231: Focus of JTabbedPane(with Scrollable tablayout) changes on change in LookAndFeel
• ... and 4 more: https://git.openjdk.org/jdk/compare/cba09cd10d4e4482852a317786242836419c313b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e12f7409)
• 00: Full (d3d84874)

[jsikstro]

Changes look good. Some comments while looking at this:

save_marks was public and is now private, which is fine since it is only called internally.

These two member variables are not initialized in the constructor like all other member variables:

HeapWord* _young_gen_saved_top;
HeapWord* _old_gen_saved_top;

The implementation order for most methods in serialHeap.cpp is quite different from the declaration/definition order in serialHeap.hpp, which is something we might also want to fix.

[albertnetymk]

These two member variables are not initialized in the constructor like all other member variables

Fixed.

The implementation order for most methods in serialHeap.cpp is quite different from the declaration/definition order in serialHeap.hpp, which is something we might also want to fix.

Filed a new ticket: https://bugs.openjdk.org/browse/JDK-8373339

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit 655e9cd.
Since your change was applied there have been 24 commits pushed to the master branch:

• b58e3b6: 8373227: Test java/net/httpclient/http2/StreamFlowControlTest.java failed: should sleep time be raised?
• 8eaeb69: 8372589: VM crashes on init when NonNMethodCodeHeapSize is set too small and UseTransparentHugePages is enabled
• b60ac71: 8364490: Fatal error on large SpecTrapLimitExtraEntries value
• ... and 21 more: https://git.openjdk.org/jdk/compare/cba09cd10d4e4482852a317786242836419c313b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 655e9cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.