8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException

[jaikiran]

Can I please get a review of this test-only change which removes the testng specific timeout from a test method?

As noted in https://bugs.openjdk.org/browse/JDK-8255463, the test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java fails intermittently with:

test InheritedChannelTest.test("StateTest", java.util.ImmutableCollections$List12@d28f210): failure [30001ms]
org.testng.internal.thread.ThreadTimeoutException: Method InheritedChannelTest.test() didn't finish within the time-out 30000

With the proposed change in this PR, it now relies on jtreg test timeout (default of 120 seconds). If the test continues to timeout for whatever reason, then jtreg will be able to capture the relevant thread dumps of the incomplete process (launched in this test method) to help debug the issue.

The existing 30 second timeout on the test method doesn't play any role in what the test verifies, so removing it doesn't change that verification.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException (Bug - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Daniel Jeliński (@djelinski - Reviewer)
• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28721/head:pull/28721
$ git checkout pull/28721

Update a local copy of the PR:
$ git checkout pull/28721
$ git pull https://git.openjdk.org/jdk.git pull/28721/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28721

View PR using the GUI difftool:
$ git pr show -t 28721

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28721.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255463: java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed with ThreadTimeoutException

Reviewed-by: dfuchs, djelinski, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 831fe94: 8373255: Unexpected iobj and ipdb files after JDK-8370438
• 8c8d21d: 8373295: Wrong log tag for UseCompressedOops ergo setting
• a4eb57c: 8367028: compiler/c2/irTests/TestFloat16ScalarOperations.java failing intermittently because of constant folding
• ... and 3 more: https://git.openjdk.org/jdk/compare/786833cd1bf8eda1cef25da392a055f4eb371abf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e48ead51)

[dfuch]

Looks trivial to me.

[bplb]

Looks fine.

[jaikiran]

Thank you all for the reviews.

[jaikiran]

/integrate

[openjdk]

Going to push as commit a262212.
Since your change was applied there have been 11 commits pushed to the master branch:

• eef9813: 8371446: VectorAPI: Add unit tests for masks from various long values
• 7f9951a: 8373207: Make DeferredStatic class template constant initializable
• 1ae4a6c: 8373101: JdkClient and JdkServer test classes ignore namedGroups field
• ... and 8 more: https://git.openjdk.org/jdk/compare/786833cd1bf8eda1cef25da392a055f4eb371abf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit a262212.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.