8373428: Refine variables with the same name in nested scopes in PhaseChaitin::gather_lrg_masks

[Hamlin-Li]

Hi,
Can you help to review this trivial patch?

In PhaseChaitin::gather_lrg_masks, several variables have the same name in nested scopes, it looks like following code snippet.
{
A a;
{
A a;
}
}

This is not helpful to code readability, in particular in a long method like gather_lrg_masks, better to rename them.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373428: Refine variables with the same name in nested scopes in PhaseChaitin::gather_lrg_masks (Enhancement - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28748/head:pull/28748
$ git checkout pull/28748

Update a local copy of the PR:
$ git checkout pull/28748
$ git pull https://git.openjdk.org/jdk.git pull/28748/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28748

View PR using the GUI difftool:
$ git pr show -t 28748

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28748.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373428: Refine variables with the same name in nested scopes in PhaseChaitin::gather_lrg_masks

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• 692edc4: 8373443: Update --release 26 symbol information for JDK 26 build 27
• 2a1c676: 8373464: Test JdkManagementCheckSince.java fails after JDK-8369736
• b0bd0c3: 8372759: Test build/AbsPathsInImage.java fails after JDK-8370438
• ... and 50 more: https://git.openjdk.org/jdk/compare/ed5fc9ad2defb75ea5a68fe6427a591376ce6d6b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3a0f08a9)

[Hamlin-Li]

@phohensee Thank you!

[Hamlin-Li]

/integrate

[openjdk]

Going to push as commit 3559eec.
Since your change was applied there have been 89 commits pushed to the master branch:

• ad6611a: 8371347: Move the ObjectMonitorTable to a separate new file
• 895232f: 8372731: Detailed authentication failure messages
• 5141e1a: 8373497: SpinCriticalSection should use SpinYield
• ... and 86 more: https://git.openjdk.org/jdk/compare/ed5fc9ad2defb75ea5a68fe6427a591376ce6d6b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Hamlin-Li Pushed as commit 3559eec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.