8182043: Access to Windows Large Icons

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java

@@ -278,10 +278,9 @@ public Icon getSystemIcon(File f) {
     * @param width width of the icon in user coordinate system.
     * @param height height of the icon in user coordinate system.
     * @return an icon as it would be displayed by a native file chooser
-    * or null if invalid parameters are passed such as reference to a
-    * non-existent file.
-    * @throws IllegalArgumentException if invalid parameter such
-    * as negative size or null file reference is passed.
+    * or null for a non-existent or inaccessible file.
+    * @throws IllegalArgumentException if an invalid parameter such
+    * as a negative size or a null file reference is passed.
     * @see JFileChooser#getIcon
     * @see AbstractMultiResolutionImage
     * @see FileSystemView#getSystemIcon(File)
@@ -292,8 +291,8 @@ public Icon getSystemIcon(File f, int width, int height) {
             throw new IllegalArgumentException("Icon size can not be below 1");
         }
 
-        if (f == null){
-            throw new IllegalArgumentException("File reference should be specified");
+        if (f == null) {
+            throw new IllegalArgumentException("The file reference should not be null");
         }
 
         if(!f.exists()) {

test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java

@@ -28,6 +28,7 @@
  * sun.awt.shell.ShellFolder
  * @run main SystemIconTest
  */
+import javax.swing.Icon;
 import javax.swing.ImageIcon;
 import javax.swing.filechooser.FileSystemView;
 import java.awt.image.MultiResolutionImage;
@@ -55,18 +56,15 @@ static void testSystemIcon() {
     }
 
     static void negativeTests() {
-        ImageIcon icon;
-        boolean gotException = false;
+        Icon icon;
         try {
-            icon = (ImageIcon) fsv.getSystemIcon(new File("."), -1, 16);
-        } catch (IllegalArgumentException iae) {
-            gotException = true;
-        }
-        if (!gotException) {
+            icon = fsv.getSystemIcon(new File("."), -1, 16);
             throw new RuntimeException("Negative size icon should throw invalid argument exception");
+        } catch (IllegalArgumentException iae) {
+            // Expected
         }
 
-        icon = (ImageIcon) fsv.getSystemIcon(new File("thereisdefinitelynosuchfile.why"),
+        icon = fsv.getSystemIcon(new File("thereisdefinitelynosuchfile.why"),
                 16, 16);
         if (icon != null) {
             throw new RuntimeException("Icons for files with invalid names should be null");