Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263200: Add -XX:StressCCP to CTW #2877

Closed
wants to merge 2 commits into from
Closed

Conversation

iignatev
Copy link
Member

@iignatev iignatev commented Mar 8, 2021

Hi all,

could you please review the tiny patch which adds -XX:+StressCCP flag to CTW testlibrary?

from JBS:

similar to StressLCM, StressGCM, and StressIGVN flags, recently introduced (by JDK-8256535) StressCCP can increase the probability to find compiler bugs, hence it makes sense to add this flag to CTW testlibrary.

testing:

  • test/hotspot/jtreg/applications/ctw/ 20 times on {linux,windows,macosx}-x64
  • testlibrary_tests/ctw/ on macosx-x64

Thanks,
-- Igor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2877/head:pull/2877
$ git checkout pull/2877

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2021

👋 Welcome back iignatyev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8263200 8263200: Add -XX:StressCCP to CTW Mar 8, 2021
@openjdk
Copy link

openjdk bot commented Mar 8, 2021

@iignatev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 8, 2021
@iignatev iignatev marked this pull request as ready for review March 8, 2021 18:19
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Mar 8, 2021

@iignatev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263200: Add -XX:StressCCP to CTW

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a2b8858: 8263041: Shenandoah: Cleanup C1 keep alive barrier check
  • 1f9ed90: 8219555: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 8, 2021
@iignatev
Copy link
Member Author

iignatev commented Mar 8, 2021

Thanks, Vladimir

/integrate

@openjdk openjdk bot closed this Mar 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2021
@openjdk
Copy link

openjdk bot commented Mar 8, 2021

@iignatev Since your change was applied there have been 2 commits pushed to the master branch:

  • a2b8858: 8263041: Shenandoah: Cleanup C1 keep alive barrier check
  • 1f9ed90: 8219555: compiler/jvmci/compilerToVM/IsMatureTest.java fails with Unexpected isMature state for multiple times invoked method: expected false to equal true

Your commit was automatically rebased without conflicts.

Pushed as commit 17853ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants