8373552: ExactConversionsSupport: bad JLS links in javadoc#28775
8373552: ExactConversionsSupport: bad JLS links in javadoc#28775biboudis wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into |
|
@biboudis This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 56 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
liach
left a comment
There was a problem hiding this comment.
Sure, this works. The original javadoc render is "See Java Language Specification:" but "See: JLS xxx" would work too.
|
Ideally we would use something like a preview note, but this is now turned into a JEP so a stopgap measure is better. |
irisclark
left a comment
There was a problem hiding this comment.
Looks good for now. Note that once the feature is standardized and the new sections are integrated into the JLS, you'll need to update the references to use @jls.
|
/integrate |
|
Going to push as commit 9a23f8a.
Your commit was automatically rebased without conflicts. |
Add relative links to the spec URL of primitive-types-in-patterns-instanceof-switch-jls.html
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28775/head:pull/28775$ git checkout pull/28775Update a local copy of the PR:
$ git checkout pull/28775$ git pull https://git.openjdk.org/jdk.git pull/28775/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28775View PR using the GUI difftool:
$ git pr show -t 28775Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28775.diff
Using Webrev
Link to Webrev Comment