Skip to content

8373552: ExactConversionsSupport: bad JLS links in javadoc#28775

Closed
biboudis wants to merge 1 commit intoopenjdk:masterfrom
biboudis:JDK-8373552
Closed

8373552: ExactConversionsSupport: bad JLS links in javadoc#28775
biboudis wants to merge 1 commit intoopenjdk:masterfrom
biboudis:JDK-8373552

Conversation

@biboudis
Copy link
Member

@biboudis biboudis commented Dec 11, 2025

Add relative links to the spec URL of primitive-types-in-patterns-instanceof-switch-jls.html


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373552: ExactConversionsSupport: bad JLS links in javadoc (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28775/head:pull/28775
$ git checkout pull/28775

Update a local copy of the PR:
$ git checkout pull/28775
$ git pull https://git.openjdk.org/jdk.git pull/28775/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28775

View PR using the GUI difftool:
$ git pr show -t 28775

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28775.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2025

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373552: ExactConversionsSupport: bad JLS links in javadoc

Reviewed-by: liach, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@biboudis The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@biboudis biboudis marked this pull request as ready for review December 11, 2025 21:51
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 11, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2025

Webrevs

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this works. The original javadoc render is "See Java Language Specification:" but "See: JLS xxx" would work too.

@liach
Copy link
Member

liach commented Dec 15, 2025

Ideally we would use something like a preview note, but this is now turned into a JEP so a stopgap measure is better.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2025
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. Note that once the feature is standardized and the new sections are integrated into the JLS, you'll need to update the references to use @jls.

@biboudis
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

Going to push as commit 9a23f8a.
Since your change was applied there have been 75 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2025
@openjdk openjdk bot closed this Dec 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 17, 2025
@openjdk
Copy link

openjdk bot commented Dec 17, 2025

@biboudis Pushed as commit 9a23f8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants