8372592: Adjust logger usage in java2d tests#28778
8372592: Adjust logger usage in java2d tests#28778prrace wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
|
@prrace This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
LGTM |
|
|
||
| static final boolean SAVE_IMAGE = false; | ||
|
|
||
| // initialize j.u.l Looger: |
|
|
||
| static final boolean SAVE_IMAGE = false; | ||
|
|
||
| // initialize j.u.l Looger: |
| static final boolean SAVE_IMAGE = false; | ||
| static final boolean SERIALIZE = false; | ||
|
|
||
| // initialize j.u.l Looger: |
|
/integrate |
|
Going to push as commit e65e068.
Your commit was automatically rebased without conflicts. |
We had a previous mysterious failure that looks like it was due to a logger being gc'd.
To prevent that update all the marlin tests to use a logger stored in a static.
The 'final' modifier probably isn't necessary for this but is harmless, I'm doing the minimum here
so I don't want to go change log -> LOG everywhere just because its now final.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28778/head:pull/28778$ git checkout pull/28778Update a local copy of the PR:
$ git checkout pull/28778$ git pull https://git.openjdk.org/jdk.git pull/28778/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28778View PR using the GUI difftool:
$ git pr show -t 28778Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28778.diff
Using Webrev
Link to Webrev Comment