Skip to content

8372592: Adjust logger usage in java2d tests#28778

Closed
prrace wants to merge 1 commit intoopenjdk:masterfrom
prrace:logger
Closed

8372592: Adjust logger usage in java2d tests#28778
prrace wants to merge 1 commit intoopenjdk:masterfrom
prrace:logger

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Dec 11, 2025

We had a previous mysterious failure that looks like it was due to a logger being gc'd.
To prevent that update all the marlin tests to use a logger stored in a static.
The 'final' modifier probably isn't necessary for this but is harmless, I'm doing the minimum here
so I don't want to go change log -> LOG everywhere just because its now final.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8372592: Adjust logger usage in java2d tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28778/head:pull/28778
$ git checkout pull/28778

Update a local copy of the PR:
$ git checkout pull/28778
$ git pull https://git.openjdk.org/jdk.git pull/28778/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28778

View PR using the GUI difftool:
$ git pr show -t 28778

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28778.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372592: Adjust logger usage in java2d tests

Reviewed-by: kizune, serb, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8372592 8372592: Adjust logger usage in java2d tests Dec 11, 2025
@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 11, 2025
@openjdk
Copy link

openjdk bot commented Dec 11, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 11, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2025

Webrevs

Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2025
@bourgesl
Copy link
Contributor

LGTM


static final boolean SAVE_IMAGE = false;

// initialize j.u.l Looger:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looger -> logger


static final boolean SAVE_IMAGE = false;

// initialize j.u.l Looger:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

static final boolean SAVE_IMAGE = false;
static final boolean SERIALIZE = false;

// initialize j.u.l Looger:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@prrace
Copy link
Contributor Author

prrace commented Dec 12, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

Going to push as commit e65e068.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2025
@openjdk openjdk bot closed this Dec 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@prrace Pushed as commit e65e068.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

6 participants